1.4: harden frontend builds against corrupted assets - #4099
Open
Daniiiil1 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Daniil Mordanov <mordanovdania@gmail.com>
Daniiiil1
marked this pull request as ready for review
August 7, 2026 11:45
| "dev": "vite --host", | ||
| "build": "NODE_ENV=production vite build", | ||
| "build": "NODE_ENV=production vite build && bun run validate-build", | ||
| "validate-build": "bun scripts/validate-build.ts", |
Member
There was a problem hiding this comment.
This is not being used in CI, what is the point ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This targets the exact observed failure in #4091: the corrupted JS chunk was NUL-interleaved and would now fail the build instead of being published. Bun 1.3.14 also matches current master, removing the old 1.0.3 runtime implicated in the write corruption.
Addresses #4091 for
1.4-dev.Testing