frontend: version-chooser: update bootstrap when changing BlueOS to a stable#3636
Open
nicoschmdt wants to merge 1 commit intobluerobotics:masterfrom
Open
frontend: version-chooser: update bootstrap when changing BlueOS to a stable#3636nicoschmdt wants to merge 1 commit intobluerobotics:masterfrom
nicoschmdt wants to merge 1 commit intobluerobotics:masterfrom
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideParameterize bootstrap update to avoid redundant reloads, auto-update bootstrap on stable version selection, and add stable-version detection. Sequence diagram for stable version selection and bootstrap updatesequenceDiagram
participant User
participant VersionChooser
participant Backend
participant Browser
User->>VersionChooser: Selects a version (setVersion)
VersionChooser->>VersionChooser: Checks if tag is stable (isStable)
alt Tag is stable
VersionChooser->>Backend: POST /bootstrap/current (setBootstrapVersion, reload=false)
end
VersionChooser->>Backend: POST /version/current
Backend-->>VersionChooser: Responds
VersionChooser->>VersionChooser: Show success message
VersionChooser->>Browser: Reload page (if reload=true in setBootstrapVersion)
Class diagram for updated VersionChooser methodsclassDiagram
class VersionChooser {
+async setBootstrapVersion(version: string, reload = true)
+async setVersion(args: string | string[])
+isStable(tag: string): boolean
+isBeingDeleted(image: Version)
-updating_bootstrap: boolean
-deleting: string
}
class VCU {
+isSemVer(tag: string): boolean
}
VersionChooser --> VCU: uses
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: #2896
Summary by Sourcery
Automatically update the bootstrap version to match semver-stable BlueOS tags without forcing a page reload and make bootstrap reload behavior configurable.
Bug Fixes:
Enhancements: