Some fixes for Bosch XDK110 implementation #269
Quality Gate failed
Failed conditions
3 Security Hotspots
D Maintainability Rating on New Code (required ≥ A)
See analysis details on SonarQube Cloud
Catch issues before they fail your Quality Gate with our IDE extension
SonarQube for IDE
Annotations
Check failure on line 171 in src/bluetooth.h
sonarqubecloud / SonarCloud Code Analysis
Replace this macro by "const", "constexpr" or an "enum".
See more on https://sonarcloud.io/project/issues?id=bluekitchen_btstack&issues=AZ0aQGzL_VoME7_WxVhd&open=AZ0aQGzL_VoME7_WxVhd&pullRequest=269
Check warning on line 125 in platform/freertos/btstack_run_loop_freertos.c
sonarqubecloud / SonarCloud Code Analysis
Make the type of this variable a pointer-to-const. The current type of "next" is "struct btstack_timer_source *".
See more on https://sonarcloud.io/project/issues?id=bluekitchen_btstack&issues=AZ0aQG9I_VoME7_WxVjc&open=AZ0aQG9I_VoME7_WxVjc&pullRequest=269
Check warning on line 149 in platform/freertos/btstack_run_loop_freertos.c
sonarqubecloud / SonarCloud Code Analysis
Declare the variable "it" inside the loop.
See more on https://sonarcloud.io/project/issues?id=bluekitchen_btstack&issues=AZ0aQG9I_VoME7_WxVjd&open=AZ0aQG9I_VoME7_WxVjd&pullRequest=269
Check warning on line 1535 in src/hci.c
sonarqubecloud / SonarCloud Code Analysis
Make the type of this parameter a pointer-to-const. The current type of "packet" is "unsigned char *".
See more on https://sonarcloud.io/project/issues?id=bluekitchen_btstack&issues=AZ0aQG1s_VoME7_WxVit&open=AZ0aQG1s_VoME7_WxVit&pullRequest=269
Check failure on line 178 in src/bluetooth.h
sonarqubecloud / SonarCloud Code Analysis
Replace this macro by "const", "constexpr" or an "enum".
See more on https://sonarcloud.io/project/issues?id=bluekitchen_btstack&issues=AZ0aQGzL_VoME7_WxVhk&open=AZ0aQGzL_VoME7_WxVhk&pullRequest=269
Check failure on line 150 in src/bluetooth.h
sonarqubecloud / SonarCloud Code Analysis
Replace this macro by "const", "constexpr" or an "enum".
See more on https://sonarcloud.io/project/issues?id=bluekitchen_btstack&issues=AZ0aQGzL_VoME7_WxVhJ&open=AZ0aQGzL_VoME7_WxVhJ&pullRequest=269
Check warning on line 4286 in src/hci.c
sonarqubecloud / SonarCloud Code Analysis
Complete the task associated to this "TODO" comment.
See more on https://sonarcloud.io/project/issues?id=bluekitchen_btstack&issues=AZ0aQG1r_VoME7_WxVii&open=AZ0aQG1r_VoME7_WxVii&pullRequest=269
Check failure on line 197 in src/bluetooth.h
sonarqubecloud / SonarCloud Code Analysis
Replace this macro by "const", "constexpr" or an "enum".
See more on https://sonarcloud.io/project/issues?id=bluekitchen_btstack&issues=AZ0aQGzL_VoME7_WxVh1&open=AZ0aQGzL_VoME7_WxVh1&pullRequest=269
Check warning on line 331 in chipset/em9301/btstack_chipset_em9301.c
sonarqubecloud / SonarCloud Code Analysis
Complete the task associated to this "TODO" comment.
See more on https://sonarcloud.io/project/issues?id=bluekitchen_btstack&issues=AZ0aQG9w_VoME7_WxVjl&open=AZ0aQG9w_VoME7_WxVjl&pullRequest=269
Check warning on line 424 in src/hci.c
sonarqubecloud / SonarCloud Code Analysis
Make the type of this parameter a pointer-to-const. The current type of "connection" is "hci_connection_t *".
See more on https://sonarcloud.io/project/issues?id=bluekitchen_btstack&issues=AZ0aQG1s_VoME7_WxVio&open=AZ0aQG1s_VoME7_WxVio&pullRequest=269
Check warning on line 2009 in src/hci.c
sonarqubecloud / SonarCloud Code Analysis
Remove the commented out code.
See more on https://sonarcloud.io/project/issues?id=bluekitchen_btstack&issues=AZ0aQG1s_VoME7_WxVjW&open=AZ0aQG1s_VoME7_WxVjW&pullRequest=269
Check failure on line 136 in src/bluetooth.h
sonarqubecloud / SonarCloud Code Analysis
Replace this macro by "const", "constexpr" or an "enum".
See more on https://sonarcloud.io/project/issues?id=bluekitchen_btstack&issues=AZ0aQGzL_VoME7_WxVg7&open=AZ0aQGzL_VoME7_WxVg7&pullRequest=269
Check failure on line 172 in src/bluetooth.h
sonarqubecloud / SonarCloud Code Analysis
Replace this macro by "const", "constexpr" or an "enum".
See more on https://sonarcloud.io/project/issues?id=bluekitchen_btstack&issues=AZ0aQGzL_VoME7_WxVhe&open=AZ0aQGzL_VoME7_WxVhe&pullRequest=269
Check failure on line 151 in src/bluetooth.h
sonarqubecloud / SonarCloud Code Analysis
Replace this macro by "const", "constexpr" or an "enum".
See more on https://sonarcloud.io/project/issues?id=bluekitchen_btstack&issues=AZ0aQGzL_VoME7_WxVhK&open=AZ0aQGzL_VoME7_WxVhK&pullRequest=269
Check warning on line 1937 in src/hci.c
sonarqubecloud / SonarCloud Code Analysis
Merge this "if" statement with the enclosing one.
See more on https://sonarcloud.io/project/issues?id=bluekitchen_btstack&issues=AZ0aQG1s_VoME7_WxVi2&open=AZ0aQG1s_VoME7_WxVi2&pullRequest=269
Check warning on line 2019 in src/hci.c
sonarqubecloud / SonarCloud Code Analysis
Remove the commented out code.
See more on https://sonarcloud.io/project/issues?id=bluekitchen_btstack&issues=AZ0aQG1s_VoME7_WxVjX&open=AZ0aQG1s_VoME7_WxVjX&pullRequest=269
Check warning on line 334 in chipset/em9301/btstack_chipset_em9301.c
sonarqubecloud / SonarCloud Code Analysis
unused function 'chipset_em9301_init'
See more on https://sonarcloud.io/project/issues?id=bluekitchen_btstack&issues=AZ0aQG9w_VoME7_WxVjm&open=AZ0aQG9w_VoME7_WxVjm&pullRequest=269
Check failure on line 327 in src/bluetooth.h
sonarqubecloud / SonarCloud Code Analysis
Replace this macro by "const", "constexpr" or an "enum".
See more on https://sonarcloud.io/project/issues?id=bluekitchen_btstack&issues=AZ0aQGzL_VoME7_WxVh4&open=AZ0aQGzL_VoME7_WxVh4&pullRequest=269
Check warning on line 3316 in src/hci.c
sonarqubecloud / SonarCloud Code Analysis
Remove the commented out code.
See more on https://sonarcloud.io/project/issues?id=bluekitchen_btstack&issues=AZ0aQG1s_VoME7_WxVja&open=AZ0aQG1s_VoME7_WxVja&pullRequest=269
Check warning on line 149 in platform/freertos/btstack_run_loop_freertos.c
sonarqubecloud / SonarCloud Code Analysis
Remove this redundant cast.
See more on https://sonarcloud.io/project/issues?id=bluekitchen_btstack&issues=AZ0aQG9I_VoME7_WxVje&open=AZ0aQG9I_VoME7_WxVje&pullRequest=269
Check failure on line 179 in src/bluetooth.h
sonarqubecloud / SonarCloud Code Analysis
Replace this macro by "const", "constexpr" or an "enum".
See more on https://sonarcloud.io/project/issues?id=bluekitchen_btstack&issues=AZ0aQGzL_VoME7_WxVhl&open=AZ0aQGzL_VoME7_WxVhl&pullRequest=269
Check warning on line 4907 in src/hci.c
sonarqubecloud / SonarCloud Code Analysis
Make the type of this parameter a pointer-to-const. The current type of "address" is "unsigned char *".
See more on https://sonarcloud.io/project/issues?id=bluekitchen_btstack&issues=AZ0aQG1s_VoME7_WxVjP&open=AZ0aQG1s_VoME7_WxVjP&pullRequest=269
Check failure on line 134 in src/bluetooth.h
sonarqubecloud / SonarCloud Code Analysis
Replace this macro by "const", "constexpr" or an "enum".
See more on https://sonarcloud.io/project/issues?id=bluekitchen_btstack&issues=AZ0aQGzL_VoME7_WxVg5&open=AZ0aQGzL_VoME7_WxVg5&pullRequest=269
Check failure on line 135 in src/bluetooth.h
sonarqubecloud / SonarCloud Code Analysis
Replace this macro by "const", "constexpr" or an "enum".
See more on https://sonarcloud.io/project/issues?id=bluekitchen_btstack&issues=AZ0aQGzL_VoME7_WxVg6&open=AZ0aQGzL_VoME7_WxVg6&pullRequest=269
Check warning on line 5028 in src/hci.c
sonarqubecloud / SonarCloud Code Analysis
Make the type of this parameter a pointer-to-const. The current type of "addr" is "unsigned char *".
See more on https://sonarcloud.io/project/issues?id=bluekitchen_btstack&issues=AZ0aQG1s_VoME7_WxVjR&open=AZ0aQG1s_VoME7_WxVjR&pullRequest=269