Skip to content

Only allow some functions internally/for testing#5697

Merged
chands10 merged 1 commit intobloomberg:mainfrom
chands10:hide_retries
Feb 5, 2026
Merged

Only allow some functions internally/for testing#5697
chands10 merged 1 commit intobloomberg:mainfrom
chands10:hide_retries

Conversation

@chands10
Copy link
Contributor

@chands10 chands10 commented Jan 28, 2026

/plugin-branch hide_retries

mohitkhullar
mohitkhullar previously approved these changes Jan 28, 2026
Copy link
Contributor

@mohitkhullar mohitkhullar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 0/0 tests failed ⚠.

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
insert_lots
cdb2api_addl_cfg
consumer_non_atomic_default_consumer_generated
insert_lots_ssl_generated
reco-ddlk-sql

@chands10 chands10 force-pushed the hide_retries branch 2 times, most recently from e4e011d to 7956bc2 Compare February 3, 2026 21:11
@chands10 chands10 changed the title Hide retries in cdb2sql Only allow retry functions internally/for testing Feb 3, 2026
@chands10 chands10 force-pushed the hide_retries branch 2 times, most recently from 0c684bb to 8c43214 Compare February 3, 2026 21:50
@chands10 chands10 changed the title Only allow retry functions internally/for testing Only allow some functions internally/for testing Feb 3, 2026
@chands10 chands10 force-pushed the hide_retries branch 3 times, most recently from 5ee5362 to 92dc340 Compare February 3, 2026 22:50
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
reco-ddlk-sql
consumer_non_atomic_default_consumer_generated
sc_transactional_rowlocks_generated
insert_lots_ssl_generated
insert_lots

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
truncatesc_offline_generated [core dumped]
queuedb_rollover
reco-ddlk-sql
consumer_non_atomic_default_consumer_generated
dohsql_leaks
insert_lots_ssl_generated
insert_lots

Signed-off-by: Salil Chandra <schandra107@bloomberg.net>
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: 0/0 tests failed ⚠.

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
consumer_non_atomic_default_consumer_generated
sc_transactional_rowlocks_generated
sc_downgrade
insert_lots_ssl_generated
insert_lots
reco-ddlk-sql

Copy link
Contributor

@mohitkhullar mohitkhullar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chands10
Copy link
Contributor Author

chands10 commented Feb 5, 2026

Thanks Mohit!!

@chands10 chands10 merged commit 1fb77c6 into bloomberg:main Feb 5, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments