Skip to content

Assert no schemalk during distributed commit#5680

Merged
markhannum merged 4 commits intobloomberg:mainfrom
markhannum:assert_no_schemalk
Feb 10, 2026
Merged

Assert no schemalk during distributed commit#5680
markhannum merged 4 commits intobloomberg:mainfrom
markhannum:assert_no_schemalk

Conversation

@markhannum
Copy link
Copy Markdown
Contributor

This PR cleans up cases where we call distributed-commit unnecessarily.

Copy link
Copy Markdown

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 18/639 tests failed ⚠.

The first 10 failing tests are:
queuedb_multimeta [core dumped]
rowlock_update [core dumped]
queuedb_locks [core dumped]
consumer_snapshot_generated [core dumped]
consumer [core dumped]
vutf8_rowlocks [core dumped]
vutf8_rowlocks_off_osql_odh_blob_generated [core dumped]
sql [core dumped]
trigger_lock_inversion [core dumped]
truncatesc_offline_generated

@markhannum markhannum force-pushed the assert_no_schemalk branch 2 times, most recently from 456aea0 to c94856a Compare January 21, 2026 20:16
Copy link
Copy Markdown

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
queuedb_rollover
reco-ddlk-sql

@markhannum markhannum force-pushed the assert_no_schemalk branch 2 times, most recently from eefda31 to 4b5518e Compare January 22, 2026 00:54
Copy link
Copy Markdown

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
sc_resume
sc_transactional_rowlocks_generated
insert_lots_ssl_generated
insert_lots
reco-ddlk-sql

@markhannum markhannum force-pushed the assert_no_schemalk branch 12 times, most recently from 57d41e7 to 1bdc40a Compare January 24, 2026 00:41
Copy link
Copy Markdown

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: 0/0 tests failed ⚠.

Copy link
Copy Markdown

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: 7/639 tests failed ⚠.

The first 10 failing tests are:
logfill
consumer_non_atomic_default_consumer_generated
sc_transactional_rowlocks_generated
tunables
sc_downgrade
insert_lots_ssl_generated
insert_lots

@markhannum markhannum force-pushed the assert_no_schemalk branch 2 times, most recently from 0039838 to 8aca793 Compare January 26, 2026 01:02
Copy link
Copy Markdown

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: 7/639 tests failed ⚠.

The first 10 failing tests are:
consumer_non_atomic_default_consumer_generated
sc_transactional_rowlocks_generated
tunables
truncatesc_offline_generated
insert_lots_ssl_generated
insert_lots
reco-ddlk-sql

Copy link
Copy Markdown

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 2/639 tests failed ⚠.

The first 10 failing tests are:
consumer_non_atomic_default_consumer_generated
reco-ddlk-sql

Copy link
Copy Markdown

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 6/639 tests failed ⚠.

The first 10 failing tests are:
consumer_non_atomic_default_consumer_generated
sc_transactional_rowlocks_generated
insert_lots_ssl_generated
insert_lots
sc_truncate_multiddl_generated
reco-ddlk-sql

Copy link
Copy Markdown

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
silogdel
reco-ddlk-sql
cdb2api_addl_cfg
consumer_non_atomic_default_consumer_generated
phys_rep_tiered_firstfile_generated

Copy link
Copy Markdown

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 0/0 tests failed ⚠.

Copy link
Copy Markdown

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
incremental_backup_usenames
silogdel
reco-ddlk-sql
analyze
cdb2api_addl_cfg
consumer_non_atomic_default_consumer_generated
sc_transactional_rowlocks_generated
lock_views

Copy link
Copy Markdown

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
silogdel [core dumped]
sc_truncate_lockorder_generated
consumer
cdb2api_addl_cfg
consumer_non_atomic_default_consumer_generated
truncatesc_offline_generated
reco-ddlk-sql

Copy link
Copy Markdown

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
silogdel [core dumped]
sc_timepart
cdb2api_addl_cfg
consumer_non_atomic_default_consumer_generated
sc_transactional_rowlocks_generated
reco-ddlk-sql

Copy link
Copy Markdown

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
silogdel [core dumped]
cdb2api_addl_cfg
consumer_non_atomic_default_consumer_generated
reco-ddlk-sql

@markhannum markhannum force-pushed the assert_no_schemalk branch 2 times, most recently from d839075 to ad0a7e2 Compare February 1, 2026 22:07
Copy link
Copy Markdown

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
silogdel [core dumped]
truncoplog_timebased_generated
truncoplog_noprotobuf_generated
tmptbl_leak_zeropool_generated
cdb2api_addl_cfg
consumer_non_atomic_default_consumer_generated
sc_downgrade
truncatesc_offline_generated

@markhannum markhannum force-pushed the assert_no_schemalk branch 2 times, most recently from 102b22a to 05ea091 Compare February 5, 2026 11:59
Copy link
Copy Markdown

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
consumer_non_atomic_default_consumer_generated
reco-ddlk-sql

Copy link
Copy Markdown

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
sp_snapshot_generated
reco-ddlk-sql
commit_lsn_map
consumer_non_atomic_default_consumer_generated

@markhannum markhannum force-pushed the assert_no_schemalk branch 4 times, most recently from b800d64 to 9aeca15 Compare February 9, 2026 16:09
Copy link
Copy Markdown

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
consumer_non_atomic_default_consumer_generated

markhannum and others added 4 commits February 10, 2026 08:35
Signed-off-by: Mark Hannum <mhannum@bloomberg.net>
Signed-off-by: Mark Hannum <mhannum@bloomberg.net>
Signed-off-by: Mark Hannum <mhannum@bloomberg.net>
Signed-off-by: Mark Hannum <mhannum@bloomberg.net>
Copy link
Copy Markdown
Contributor

@dorinhogea dorinhogea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@markhannum markhannum merged commit 684922a into bloomberg:main Feb 10, 2026
4 checks passed
@markhannum markhannum deleted the assert_no_schemalk branch February 10, 2026 18:05
Copy link
Copy Markdown

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 0/0 tests failed ⚠.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants