feat: set up new Preferences page & edit/view drawers (MSQ V2)#5654
Merged
jaredcwhite merged 35 commits intomainfrom Feb 9, 2026
Merged
feat: set up new Preferences page & edit/view drawers (MSQ V2)#5654jaredcwhite merged 35 commits intomainfrom
jaredcwhite merged 35 commits intomainfrom
Conversation
✅ Deploy Preview for partners-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-flagly ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-public-seeds ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-angelopolis ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-lakeview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for partners-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-public-seeds ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-angelopolis canceled.
|
✅ Deploy Preview for bloom-flagly ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-lakeview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ludtkemorgan
approved these changes
Jan 29, 2026
Collaborator
ludtkemorgan
left a comment
ludtkemorgan
left a comment
There was a problem hiding this comment.
After moving the translation strings to the correct file this is good!
ludtkemorgan
added
1 review needed
Resolve translation issues
mcgarrye
reviewed
Feb 4, 2026
Collaborator
mcgarrye
left a comment
mcgarrye
left a comment
There was a problem hiding this comment.
First pass at the code, no visible issue. Added some comments/ideas of how we want the code to look. Can discuss further
mcgarrye
reviewed
Feb 4, 2026
Collaborator
Screen.Recording.2026-02-04.at.4.05.22.PM.movI'm seeing flashes of the old table when loading the page, is there a way to avoid that? Out of my depth on this level of frontend lol |
mcgarrye
reviewed
Feb 5, 2026
Collaborator
Author
|
Just adding a note not to forget about this: #5654 (comment) but it's since was non-blocking, I've addressed all the other feedback so I'll go ahead and get this merged! |
ludtkemorgan
pushed a commit
to metrotranscom/doorway
that referenced
this pull request
Mar 20, 2026
…-housing#5654) * feat: set up a new page for the Preferences AG table * feat: use separate set of modals for new preferences page * fix: temp rename to pull main in * feat: set up proper feature flag detection for preferences table * feat: start relocating fields for new MSQ schema * feat: viewing preferences now working correctly * feat: update seed data for newer preference schema * feat: tighten up UI in various drawers/modals * feat: keep show/hide on listing as its own option, improve view drawer * test: update backend tests for the MSQv2 changes * test: address linting issues * fix: use explicit call to save handler * feat: improve view UI * feat: use conditional CLI flag for MSQ V2 seed data * feat: additional improvements to seed data, fixing bugs in adding prefs * test: add new unit tests for the V2 Preferences page * test: cleanup, DRY * fix: lint * test: add test for viewing a preference * fix: address additional feedback QA * fix: cleanup multiple watch statements * chore: update all useMutate usage to import from shared-helpers * fix: MSG V2 seeding issues * fix: add back missing import * fix: linting * fix: use new data items * test: use new backend format in mocked requests * test: remove unused variable * fix: rename V2 "preferences" to msq and other QA feedback addressed
ludtkemorgan
pushed a commit
to metrotranscom/doorway
that referenced
this pull request
Mar 30, 2026
…-housing#5654) * feat: set up a new page for the Preferences AG table * feat: use separate set of modals for new preferences page * fix: temp rename to pull main in * feat: set up proper feature flag detection for preferences table * feat: start relocating fields for new MSQ schema * feat: viewing preferences now working correctly * feat: update seed data for newer preference schema * feat: tighten up UI in various drawers/modals * feat: keep show/hide on listing as its own option, improve view drawer * test: update backend tests for the MSQv2 changes * test: address linting issues * fix: use explicit call to save handler * feat: improve view UI * feat: use conditional CLI flag for MSQ V2 seed data * feat: additional improvements to seed data, fixing bugs in adding prefs * test: add new unit tests for the V2 Preferences page * test: cleanup, DRY * fix: lint * test: add test for viewing a preference * fix: address additional feedback QA * fix: cleanup multiple watch statements * chore: update all useMutate usage to import from shared-helpers * fix: MSG V2 seeding issues * fix: add back missing import * fix: linting * fix: use new data items * test: use new backend format in mocked requests * test: remove unused variable * fix: rename V2 "preferences" to msq and other QA feedback addressed
ludtkemorgan
pushed a commit
to metrotranscom/doorway
that referenced
this pull request
Apr 6, 2026
…-housing#5654) * feat: set up a new page for the Preferences AG table * feat: use separate set of modals for new preferences page * fix: temp rename to pull main in * feat: set up proper feature flag detection for preferences table * feat: start relocating fields for new MSQ schema * feat: viewing preferences now working correctly * feat: update seed data for newer preference schema * feat: tighten up UI in various drawers/modals * feat: keep show/hide on listing as its own option, improve view drawer * test: update backend tests for the MSQv2 changes * test: address linting issues * fix: use explicit call to save handler * feat: improve view UI * feat: use conditional CLI flag for MSQ V2 seed data * feat: additional improvements to seed data, fixing bugs in adding prefs * test: add new unit tests for the V2 Preferences page * test: cleanup, DRY * fix: lint * test: add test for viewing a preference * fix: address additional feedback QA * fix: cleanup multiple watch statements * chore: update all useMutate usage to import from shared-helpers * fix: MSG V2 seeding issues * fix: add back missing import * fix: linting * fix: use new data items * test: use new backend format in mocked requests * test: remove unused variable * fix: rename V2 "preferences" to msq and other QA feedback addressed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #5597, #5149, #5650, #5651
Description
The PR adds a new, separate screen for viewing/editing Preferences (at the path
/settings/preferences-new) which allows for managing MSQ V2 style preferences.How Can This Be Tested/Reviewed?
To seed your local DB with preferences in V2, run:
yarn setup --msqV2in theapifolderThen you can log in as a Bloomington admin in Partners and access the new page via Settings. Otherwise you'll still see the old page and seed data.
It's possible to view the two seed preferences as well as add new preferences. Unfortunately there's no easy way to flip between Edit and View for the same preference. You could try manually editing the code in the
preferences-new.tsxfor the table. I'm also not sure how easy it is to test various other statuses available in the enum.Some of the code for editing a preference is copied over and modified from the previous V1 editing, but all of the code for viewing is new, so it's possible I missed some edge cases or something in the UI could be improved. This is what I would call a "first draft".
There are also some follow-up issues which will touch on certain things in here, such as adding search, pagination, and sorting to the new preferences table.
Author Checklist:
yarn generate:clientand/or created a migration when requiredReview Process: