fix: a11y improvements for finder#5221
Merged
KrissDrawing merged 8 commits intomainfrom Jan 12, 2026
Merged
Conversation
KrissDrawing
added
wip
9 tasks
ColinBuyck
suggested changes
Aug 13, 2025
Contributor
ColinBuyck
left a comment
ColinBuyck
left a comment
There was a problem hiding this comment.
I'm noticing that the focus stays on the next button when the user changes from one page to another (within the same section). My guess is that we'll have to use the ref approach for both rather than the getElementById. You can see in the recording that the focus reset works with the section change but not the step change. Lmk if you have any questions
Screen.Recording.2025-08-13.at.7.56.28.AM.mov
Contributor
|
Oof just saw the wip label! Sorry for the premature comment 🦤 ping me when this is ready! |
ColinBuyck
removed
the
1 review needed
✅ Deploy Preview for bloom-flagly ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
KrissDrawing
added
1 review needed
✅ Deploy Preview for partners-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-public-seeds ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-lakeview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
KrissDrawing
force-pushed
the
4913/Rental-Finder-A11y
branch
from
bedd3d2 to
1f595ee
Compare
KrissDrawing
force-pushed
the
4913/Rental-Finder-A11y
branch
from
1f595ee to
2dca682
Compare
✅ Deploy Preview for bloom-angelopolis canceled.
|
✅ Deploy Preview for partners-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-public-seeds ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-angelopolis ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-lakeview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
emilyjablonski
approved these changes
Jan 6, 2026
Collaborator
emilyjablonski
left a comment
emilyjablonski
left a comment
There was a problem hiding this comment.
Thank you so much for these updates! Just need to remove the aria label and then good to merge
emilyjablonski
removed
the
1 review needed
avrittrohwer
pushed a commit
to bloom-housing/bloom-la
that referenced
this pull request
Jan 14, 2026
* fix: a11y improvements for finder * fix: use headingProps for HeadingGroup * fix: add translations
ludtkemorgan
pushed a commit
to metrotranscom/doorway
that referenced
this pull request
Feb 2, 2026
* fix: a11y improvements for finder * fix: use headingProps for HeadingGroup * fix: add translations
ludtkemorgan
pushed a commit
to metrotranscom/doorway
that referenced
this pull request
Feb 3, 2026
* fix: a11y improvements for finder * fix: use headingProps for HeadingGroup * fix: add translations
ludtkemorgan
pushed a commit
to metrotranscom/doorway
that referenced
this pull request
Feb 12, 2026
* fix: a11y improvements for finder * fix: use headingProps for HeadingGroup * fix: add translations
ludtkemorgan
pushed a commit
to metrotranscom/doorway
that referenced
this pull request
Mar 2, 2026
* fix: a11y improvements for finder * fix: use headingProps for HeadingGroup * fix: add translations
ludtkemorgan
pushed a commit
to metrotranscom/doorway
that referenced
this pull request
Mar 9, 2026
* fix: a11y improvements for finder * fix: use headingProps for HeadingGroup * fix: add translations
ludtkemorgan
pushed a commit
to metrotranscom/doorway
that referenced
this pull request
Mar 12, 2026
* fix: a11y improvements for finder * fix: use headingProps for HeadingGroup * fix: add translations
ludtkemorgan
pushed a commit
to metrotranscom/doorway
that referenced
this pull request
Mar 17, 2026
* fix: a11y improvements for finder * fix: use headingProps for HeadingGroup * fix: add translations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #4913
Description
Adds finder a11y improvements from detroit page. It will be:
How Can This Be Tested/Reviewed?
turn on screen reader and walk through
/finder.Author Checklist:
yarn generate:clientand/or created a migration when requiredReview Process: