chore: upgrade markdown-to-jsx#4715
Conversation
emilyjablonski
added
dependencies
emilyjablonski
changed the title
✅ Deploy Preview for bloom-public-seeds ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for partners-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for bloom-public-seeds ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for partners-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ludtkemorgan
left a comment
ludtkemorgan
left a comment
There was a problem hiding this comment.
I could be swayed about updating this now and upgrade the other two libraries later. But being on two different major versions could create some issues
| tinyqueue "^2.0.3" | ||
| vt-pbf "^3.1.3" | ||
|
|
||
| markdown-to-jsx@*, markdown-to-jsx@^7.7.4: |
There was a problem hiding this comment.
issue: I noticed this is not updating the markdown-to-jsx version but rather pulling in a new version. Looks like ui-seeds and ui-components are still pulling in a 6.11 version
There was a problem hiding this comment.
I haven't been able to find any issues so far, but we should test this in HBA/Doorway to make sure where we use a lot of markdown nothing is broken.
Looking at the dependabot tickets, I don't think they were upgraded due to security issues so I would lean towards upgrading it in ui-seeds and ui-components at the same time so that we are not on two different major versions
mcgarrye
added
the
needs changes
emilyjablonski
added
on hold
3 participants
Related to metrotranscom#1107 and metrotranscom#1126 and metrotranscom#1156
Description
These are the breaking release notes, looks like just Typescript. Our current version was released in 2020.
How Can This Be Tested/Reviewed?
We use markdown-to-jsx to display markdown content. Two example usages to check out are (1) the what to expect page (the first page of an application), and (2) the disclaimer page.
Author Checklist:
yarn generate:clientand/or created a migration when requiredReview Process: