Merged
Conversation
blocknotes
force-pushed
the
views-improvements
branch
from
698eb81 to
ba8559f
Compare
Fix params_to_s pushing [string] instead of string and add URL encoding via CGI.escape. Fix Flash component using "notices" CSS class for all message types instead of "warnings"/"errors". Add nil guard on Head#style_links and Store#prepare_sections navbar. Add rescue in Support.to_date for values that do not respond to to_date.
…Page DRY up duplicated update_attributes into a Views::Attributes module shared by BasicLayout and BasicComponent. Extract inline actions_buttons methods from Index and Show into a reusable ActionsButtons component. Consolidate three identical error page view_templates into an ErrorPage base class. Also adds nil guard on field access in Index and Show table/record iteration.
blocknotes
force-pushed
the
views-improvements
branch
from
ba8559f to
a849f57
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In this PR: