Conversation
60c0b1b to
bc15c44
Compare
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
rubocop
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
[rubocop] reported by reviewdog 🐶
RSpec/MultipleExpectations: Example has too many expectations [2/1].
[rubocop] reported by reviewdog 🐶
RSpec/MultipleExpectations: Example has too many expectations [3/1].
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
[rubocop] reported by reviewdog 🐶
RSpec/VerifiedDoubles: Prefer using verifying doubles over normal doubles.
[rubocop] reported by reviewdog 🐶
RSpec/MultipleExpectations: Example has too many expectations [2/1].
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
[rubocop] reported by reviewdog 🐶
RSpec/VerifiedDoubles: Prefer using verifying doubles over normal doubles.
[rubocop] reported by reviewdog 🐶
RSpec/MultipleExpectations: Example has too many expectations [3/1].
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
[rubocop] reported by reviewdog 🐶
RSpec/VerifiedDoubles: Prefer using verifying doubles over normal doubles.
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
[rubocop] reported by reviewdog 🐶
RSpec/MultipleExpectations: Example has too many expectations [3/1].
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
[rubocop] reported by reviewdog 🐶
RSpec/MultipleExpectations: Example has too many expectations [2/1].
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
[rubocop] reported by reviewdog 🐶
RSpec/MultipleExpectations: Example has too many expectations [3/1].
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
[rubocop] reported by reviewdog 🐶
RSpec/MultipleExpectations: Example has too many expectations [2/1].
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
[rubocop] reported by reviewdog 🐶
[Correctable] Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
[rubocop] reported by reviewdog 🐶
RSpec/MultipleExpectations: Example has too many expectations [2/1].
[rubocop] reported by reviewdog 🐶
RSpec/MultipleExpectations: Example has too many expectations [2/1].
41df432 to
1a8e4f1
Compare
Update gemspec constraint from ~> 1, >= 1.10.0 to ~> 2. Replace deprecated unsafe_raw(content) with raw(safe(content)) in Content page. Replace removed yield_content(&block) with plain yield in DefaultLayout. All existing tests pass with Phlex 2.4.1.
… view components Add 31 new specs bringing line coverage to 100% and branch coverage from 80.97% to 83.4%. Covers TinyAdmin.configure block form, Utils#prepare_page, Settings#load_settings idempotency, and unit specs for FieldValue, Widgets, FiltersForm (all filter types), and ActionsButtons components.
…ored methods The RBS runtime type checker was failing because signatures were stale after the Phlex 2 upgrade and code refactoring. Key changes: - Fix view_template block arity: (untyped) -> () for Phlex 2 yield pattern - Add signatures for Attributes module, ActionsButtons, and ErrorPage - Update BasicLayout/BasicComponent to include Attributes module - Add authorize! to Router, @loaded to Settings - Remove stale actions_buttons from Index/Show (now a component)
No description provided.