Scaffold elasticgraph-warehouse_lambda gem with Config#973
Merged
Conversation
jwils
requested review from
BrianSigafoos-SQ,
ayousufi,
bsorbo,
jwondrusch,
lancethomps,
myronmarston,
nicolewoch and
thomasmahoney
as code owners
jwils
force-pushed
the
joshuaw/warehouse-lambda-1-scaffold
branch
from
26fc5bf to
7d17137
Compare
myronmarston
requested changes
Jan 15, 2026
Collaborator
myronmarston
left a comment
myronmarston
left a comment
There was a problem hiding this comment.
The build failed:
+ script/update_config_artifacts --verify
Verifying config_schema.yaml...
❌ config_schema.yaml is out-of-date.
You need to run script/update_config_artifacts and commit the result to get it to pass.
jwils
force-pushed
the
joshuaw/warehouse-lambda-1-scaffold
branch
3 times, most recently
from
4cf4c6e to
55d863e
Compare
myronmarston
requested changes
Jan 16, 2026
jwils
force-pushed
the
joshuaw/warehouse-lambda-1-scaffold
branch
3 times, most recently
from
735851d to
3d20dca
Compare
myronmarston
approved these changes
Jan 17, 2026
This commit establishes the basic gem structure for elasticgraph-warehouse_lambda, a new AWS Lambda integration gem that will export ElasticGraph indexing data to S3 as gzipped JSONL files for downstream analytics pipelines and data warehouses. Key components: - Gem specification with dependencies on elasticgraph-indexer_lambda, elasticgraph-lambda_support, and aws-sdk-s3 - Config class for parsing warehouse.s3_path_prefix from YAML settings - Full RBS type signatures for type safety - 100% test coverage (7 examples) Configuration: - warehouse.s3_path_prefix (required): S3 key prefix for organizing exports Documentation: - Comprehensive README with configuration and usage overview - Updated CLAUDE.md to reflect 6 Lambda gems (was 5) - Updated CODEBASE_OVERVIEW.md with dependency diagrams - Cross-referenced README updates in elasticgraph-indexer_lambda and elasticgraph-lambda_support 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
jwils
force-pushed
the
joshuaw/warehouse-lambda-1-scaffold
branch
from
3d20dca to
b2e296b
Compare
2 tasks
jwils
added a commit
that referenced
this pull request
Apr 23, 2026
Distills the patterns Myron Marston applies when reviewing merged PRs (naming at the caller's level of abstraction, respond_to? as a code smell, wrapper-class DI pattern, load-bearing tests, RBS/YARD hygiene, etc.) into an edit-first skill. Invoked as /myron-polish, the skill walks the current branch's diff against main and applies fixes directly rather than producing review comments. It loops — re-scan, apply edits, run script/lint --fix / script/spellcheck -w / script/type_check / script/run_gem_specs — until a full iteration makes zero edits and every verification command passes. Capped at 8 iterations. Source material: Myron's review bodies and inline comments on merged PRs #974, #973, #1067, #1066, #1108, #1120, #1131, #1134, #1144, #1107. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit establishes the basic gem structure for elasticgraph-warehouse_lambda, a new AWS Lambda integration gem that will export ElasticGraph indexing data to S3 as gzipped JSONL files for downstream analytics pipelines and data warehouses.
Key components:
Configuration:
Documentation:
🤖 Generated with Claude Code