Register nested sourced_from path segments on the root index#1242
Merged
myronmarston merged 3 commits intoJun 10, 2026
Merged
Conversation
28a337f to
51f0170
Compare
myronmarston
reviewed
Jun 9, 2026
myronmarston
requested changes
Jun 9, 2026
myronmarston
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Populates
IndexDefinition#sourced_from_nested_paths_by_relationship(stubbed to{}until now). When aparent_relationshipchain resolves, its path segments are converted intoListPathSegment/ObjectPathSegments and registered on the root indexed type'sIndex, keyed by the leaf relationship name.Scope
Path registration is the only effect of a resolved chain in this PR — no nested update target is produced yet (that comes later in the PR stack). Every
parent_relationshipchain is still resolved so its configuration errors surface, but a path is registered only for relationships that actually back asourced_fromfield.Validation
Index#register_sourced_from_nested_pathsraises a clearSchemaErrorif two chains terminating at the same index share a relationship name — the runtime tracks sourced data by relationship name (__versions/__sources), so a collision can't be represented and we fail fast at schema-definition time rather than silently clobbering.Notes
to_dumpable_hash/from_hash) is already round-trip-covered inelasticgraph-schema_artifacts'sschema_spec.rb, so it isn't re-tested here.runtime_metadata.yamlchurn. A later PR will add a nestedsourced_fromschema toconfig/schema/and assert on the dumped YAML end-to-end.