-
Notifications
You must be signed in to change notification settings - Fork 1
feat: Create a dockerfile for cachew #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
67e1bcb to
48bfa66
Compare
bdfa553 to
edc19ae
Compare
Justfile
Outdated
| GIT_COMMIT := `git rev-parse HEAD 2>/dev/null || echo "unknown"` | ||
| TAG := `git rev-parse --short HEAD 2>/dev/null || echo "dev"` | ||
| RELEASE := "dist" | ||
| REGISTRY := env_var_or_default("REGISTRY", "268271485387.dkr.ecr.us-west-2.amazonaws.com") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiousity where is this? Is this an account for OSS artifacts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is internal, I think we should consider using ghcr or docker hub and then republishing internally via another mechanism
b6b6791 to
51d212c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested pushing to ghcr from this branch
Images are pushed to blox ecr account for now, repository.
Testing
Docker image is being built and pushed to ghcr.io, tested via this branch https://github.com/block/cachew/pkgs/container/cachew
Downloaded the test image ran and tested with cachew cli.
docker pull ghcr.io/block/cachew:pr-63