MB-62985 - Adding BQ vector-related utils.#51
Open
metonymic-smokey wants to merge 20 commits intoblevefrom
Open
MB-62985 - Adding BQ vector-related utils.#51metonymic-smokey wants to merge 20 commits intoblevefrom
metonymic-smokey wants to merge 20 commits intoblevefrom
Conversation
metonymic-smokey
requested review from
CascadingRadium,
Likith101,
Thejas-bhat and
abhinavdangeti
| /// Getter for is_trained | ||
| FAISS_DECLARE_GETTER(IndexBinary, int, is_trained) | ||
|
|
||
| FAISS_DECLARE_GETTER_SETTER(IndexBinary, int, is_trained) |
Member
There was a problem hiding this comment.
Could you please point out why a setter method is required for is_trained?
I do not see it being used anywhere in either the faiss or the bleve side of things.
| DEFINE_GETTER(IndexBinary, int, d) | ||
|
|
||
| DEFINE_GETTER(IndexBinary, int, is_trained) | ||
| DEFINE_SETTER(IndexBinary, int, is_trained) |
Comment on lines
+36
to
+37
| DEFINE_GETTER(IndexBinaryIVF, size_t, nlist); | ||
| DEFINE_SETTER(IndexBinaryIVF, size_t, nlist); |
Member
There was a problem hiding this comment.
nlist getter and setter not required
Member
|
first pass - will try to go deeper in the next pass thanks. |
abhinavdangeti
force-pushed
the
format
branch
from
cef8bcb to
b108645
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.