Skip to content

[PM-5108] fix: Show all owners and admins in admin portal org view - #8099

Open
r-tome wants to merge 2 commits into
mainfrom
fix/PM-5108-admin-portal-no-owner
Open

[PM-5108] fix: Show all owners and admins in admin portal org view#8099
r-tome wants to merge 2 commits into
mainfrom
fix/PM-5108-admin-portal-no-owner

Conversation

@r-tome

@r-tome r-tome commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-5108

📔 Objective

OrganizationViewModel was filtering owners and admins based on a status
derived from Organization.Status, which caused the Administrators section
to show "No results to list" even when owners existed. We were unable to
pinpoint exactly how an organization can reach the state that triggers this,
but it has been observed across multiple production support tickets.

These changes ensure customer support has all organization details available
when investigating issues:

  • Owners and admins are now shown regardless of their OrganizationUserStatusType.
    The view already renders a Status column per row so the user state remains visible.
  • Organization.Status is now displayed on the org page in the admin portal.
    Previously there was no way to see this from the UI, which made it harder
    to diagnose organization setup issues.

📸 Screenshots

image

r-tome added 2 commits July 30, 2026 13:49
OrganizationViewModel was deriving an expected OrganizationUserStatusType
from org.Status and filtering owners/admins to that single status. This
caused confirmed owners to disappear when an org was in Pending state,
which happens in the reseller flow while awaiting InitPendingOrganization.
@r-tome r-tome added the ai-review Request a Claude code review label Jul 30, 2026
@github-actions

github-actions Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the removal of the Organization.Status-derived OrganizationUserStatusType filter in OrganizationViewModel, the new Status row in _ViewInformation.cshtml, and the new OrganizationViewModelTests. Traced every consumer of Owners/Admins/OwnersDetails/AdminsDetails: the Administrators table already renders a per-row Status column, and the reseller Client Owner Email field in _OrganizationForm.cshtml is display-only — Owners is only read by the reseller CreateOrganization POST (fresh user input, no view-model construction) and is not consumed by the org Edit POST or OrganizationEditModel.Validate, so the widened result set carries no functional risk. Controller callers pass unfiltered GetManyDetailsByOrganizationAsync results, the new test namespace and BitAutoData usage match the existing Admin.Test/Models conventions, and the change is confined to the internal admin portal with no additional vault data or PII exposure beyond what the page already displays.

Code Review Details

No code findings.

@r-tome r-tome added the t:bugfix Change Type - Bugfix label Jul 30, 2026
@r-tome
r-tome marked this pull request as ready for review July 30, 2026 16:00
@r-tome
r-tome requested a review from a team as a code owner July 30, 2026 16:00
@r-tome
r-tome requested a review from JaredScar July 30, 2026 16:00
@codecov

codecov Bot commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.71%. Comparing base (ab12fbd) to head (6d5a9b7).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8099      +/-   ##
==========================================
+ Coverage   62.68%   62.71%   +0.02%     
==========================================
  Files        2296     2298       +2     
  Lines      100051   100111      +60     
  Branches     9004     9006       +2     
==========================================
+ Hits        62721    62788      +67     
+ Misses      35147    35143       -4     
+ Partials     2183     2180       -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review t:bugfix Change Type - Bugfix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant