[PM-40492] Regenerate NuGet lock files during version bump - #8097
Conversation
packages.lock.json files pin internal ProjectReference versions (e.g. "Core": "[2026.7.2, )"), so bumping Directory.Build.props's Version leaves every lock file stale until an unrelated PR happens to restore packages and picks up the churn as noise in its diff. Restore the solution with --force-evaluate right after the bump so the refreshed lock files land in the same commit/PR.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8097 +/- ##
=======================================
Coverage 62.68% 62.69%
=======================================
Files 2296 2296
Lines 100051 100051
Branches 9004 9004
=======================================
+ Hits 62721 62722 +1
+ Misses 35147 35146 -1
Partials 2183 2183 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE This PR adds a Code Review DetailsNo findings. |
https://bitwarden.atlassian.net/browse/PM-40492
Summary
packages.lock.jsonfiles pin internalProjectReferenceversions (e.g."Core": "[2026.7.2, )"), so bumpingDirectory.Build.props'sVersionleft every lock file stale until an unrelated PR happened to restore packages and picked up the churn as unrelated diff noise (e.g. [PM-41079] Extract SSRF protection into src/Libraries/SsrfProtection #8066 carried ~20 incidental2026.7.1 → 2026.7.2lock-file line changes).dotnet restore bitwarden-server.slnx --force-evaluatestep to thebump_versionjob right after the version bump, so refreshed lock files land in the same commit/PR as the version bump itself.Test plan
Directory.Build.props'sVersionand runningdotnet restore --force-evaluateregenerates the internalProjectReferenceversion pins inpackages.lock.json.workflow_dispatchon a test run.