Gate Admin database migrations behind environment variable instead of self-hosted check

[trmartin4]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-38758

📔 Objective

Helm deployments are self-hosted, but we do not want them to run the Admin-controlled database migrations.

To support this, we disconnect the running of migrations from the user's hosting method, and instead rely on an environment variable.

The value of the variable will be as follows:

Environment	Value	Result
Self-Hosted Docker deployment	Set to true in Docker initialization.	Same behavior as today, the migrations run. 👍
Self-Hosted Helm deployment	Not set (defaults to false)	Changed behavior - will NOT run now. 👍
Cloud	Not set (defaults to false)	Same behavior as today, the migrations do not run. 👍

Implementation Notes:

• I elected to move the check into the service, so that it could be tested and so that we can avoid having to use magic strings for the configuration value; if it's checked within Startup.cs the config pipeline hasn't run.
• As I introduced tests, and the service had a hard-coded 20-second startup and retry delay, I added a TimeProvider to allow testability without making every test run wait the full 20 seconds.

[codecov]

Codecov Report

❌ Patch coverage is 73.33333% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.17%. Comparing base (125b647) to head (f883857).

Files with missing lines	Patch %	Lines
src/Admin/Startup.cs	0.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7810      +/-   ##
==========================================
+ Coverage   61.14%   61.17%   +0.02%     
==========================================
  Files        2175     2175              
  Lines       96899    96904       +5     
  Branches     8738     8738              
==========================================
+ Hits        59247    59279      +32     
+ Misses      35542    35513      -29     
- Partials     2110     2112       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the change that decouples Admin database migrations from the self-hosted flag and gates them behind a new AdminSettings.RunDatabaseMigrations environment variable. The hosted service is now always registered, performs an early return when the flag is unset, and uses an injected TimeProvider so delays are testable. The Docker installer seeds adminSettings__runDatabaseMigrations=true in global.env, preserving today's Docker self-host behavior while letting Helm deployments opt out by default. Unit tests cover the unset/false gate, the success path, retry-on-DbException, and rethrow-after-max-attempts.

Code Review Details

No new findings beyond the existing (now outdated) suggestion thread on test naming, which has since been addressed in the current test names. CI signals (Codecov patch coverage 66.66% on Startup.cs, SonarCloud quality gate passing) are consistent with hard-to-cover composition-root code.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud