fix(auto-enroll-status): [PM-39004] POC pass SSO identifier as query param for auto-enroll-status#7808
Draft
Patrick-Pimentel-Bitwarden wants to merge 2 commits into
Draft
Conversation
The org SSO identifier is admin-chosen and may contain reserved URL characters (e.g. '/'), which break the existing {identifier}/auto-enroll-status path route (no route matches -> 404). Add a new GET /organizations/auto-enroll-status?identifier=... route sharing the same logic, and mark the old path route [Obsolete] (kept functional for backward compatibility).
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7808 +/- ##
==========================================
+ Coverage 61.13% 61.23% +0.09%
==========================================
Files 2173 2209 +36
Lines 96752 97722 +970
Branches 8726 8815 +89
==========================================
+ Hits 59150 59836 +686
- Misses 35490 35763 +273
- Partials 2112 2123 +11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
| sutProvider.GetDependency<IPolicyQuery>().RunAsync(organization.Id, PolicyType.ResetPassword).Returns(policy); | ||
|
|
||
| #pragma warning disable CS0618 // Type or member is obsolete - retained for backward compatibility, kept under test. | ||
| var result = await sutProvider.Sut.GetAutoEnrollStatus(organization.Id.ToString()); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-39004
📔 Objective
The org SSO identifier is admin-chosen and may contain reserved URL characters (e.g. '/'), which break the existing {identifier}/auto-enroll-status path route (no route matches -> 404).
📸 Screenshots