[PM-37953] Add OrganizationUserStatusType.Staged, Remove Ordinal Checks

[sven-bitwarden]

🎟️ Tracking

PM-37953

📔 Objective

Tip

A vast, vast majority of this PR consists of tests and migrations - each adjustment to actual business code is only a line or two.

Following the technical breakdown for settings applicable to provisioned-but-not-invited users, we are introducing a new OrganizationUserStatusType. The largest challenge in doing so, is our internal inconsistencies with how we go about checking this value, causing any new addition to suddenly be included in a random assortment of queries.

This PR makes all checks consistent - when evaluating this property, we should only be concerned about what we want included, not what we want excluded (or other nondeterministic-over-time checks).

[codecov]

Codecov Report

❌ Patch coverage is 94.87179% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.51%. Comparing base (30d873f) to head (972f300).
⚠️ Report is 7 commits behind head on main.

Files with missing lines	Patch %	Lines
...PolicyEventHandlers/SingleOrgPolicyEventHandler.cs	50.00%	0 Missing and 1 partial ⚠️
...dlers/TwoFactorAuthenticationPolicyEventHandler.cs	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7780      +/-   ##
==========================================
+ Coverage   61.05%   65.51%   +4.45%     
==========================================
  Files        2173     2173              
  Lines       96580    96598      +18     
  Branches     8691     8691              
==========================================
+ Hits        58963    63282    +4319     
+ Misses      35516    31126    -4390     
- Partials     2101     2190      +89     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the introduction of OrganizationUserStatusType.Staged (status 3) and the migration of ordinal status checks (Status >= 0, Status != 0) to explicit set-membership across C# and SQL. The change touches policy enforcement, seat-count queries, claimed-domain queries, and the Dirt member-access report, with a coordinated EF + Dapper migration and matching test additions. SQL/EF parity is consistent: every count query that previously used Status >= 0 now uses Status IN (0, 1, 2) on both sides, and every "non-invited" query now explicitly enumerates Accepted/Confirmed/Revoked. Test coverage is strong (new theory-data cases for Staged across policy requirements, integration tests for OccupiedSeatCount, SmSeatCount, ClaimedDomains, and PolicyDetails queries, and a regression test on ProviderOrganization details).

Code Review Details

No findings. The previously raised bot threads (AccessSecretsManager == true style) are already resolved.

[sonarqubecloud]

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
41.0% Duplication on New Code

See analysis details on SonarQube Cloud

[jrmccannon]

maybe make this a public ext method on org user for this project? Since its in two different tests.

Can go alongside OrgTestHelpers.cs

[jrmccannon]

One tiny thing. I'm fine if you don't do it.