Make Nx the primary build workflow for the desktop docs - #838
Open
sognefej wants to merge 1 commit into
Open
Conversation
Promotes npx nx serve desktop as the recommended build path, including native module compilation via npx nx build-native desktop, and moves the npm-script instructions to a Manual build commands section.
Contributor
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE Reviewed a documentation-only change to Code Review DetailsNo findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
📔 Objective
Updates the desktop build instructions to make
npx nx serve desktop(including native modulecompilation via
npx nx build-native desktop) the recommended build path instead of the legacynpm run electronscript. The old npm-script instructions are preserved in a new "Manual buildcommands" section rather than removed outright.
📸 Screenshots
N/A — documentation-only change.