🍒 [PM-41100] fix: Complete the VFO-1 organization-to-vault revert - #7221
Conversation
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE This is a cherry-pick of #7220 onto Code Review DetailsNo findings. Test assertions were updated in lockstep with the string changes ("Move to Organization", "Choose an organization that", "mockOrganizationName-1. Organization"), and the surrounding |
There was a problem hiding this comment.
Pull request overview
Completes the release-branch revert of the VFO-1 “Organization → Vault” terminology changes so the UI again shows “Organization” wording (and related descriptions/empty states) until the flag-gated version lands.
Changes:
- Restores
move_to_organization,move_to_org_desc, andno_orgs_to_liststring resources and removes the leftover “vault” variants. - Updates Move-to-Organization screen/ViewModel and related UI to reference the restored organization strings.
- Updates Compose UI tests to assert the reverted “Organization” copy.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ui/src/main/res/values/strings.xml | Restores organization-focused string keys and removes the vault-focused keys. |
| app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/movetoorganization/VaultMoveToOrganizationViewModel.kt | Updates app bar title to use move_to_organization. |
| app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/movetoorganization/VaultMoveToOrganizationEmpty.kt | Uses no_orgs_to_list for the empty state message. |
| app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/movetoorganization/VaultMoveToOrganizationContent.kt | Reverts dropdown label/supporting text to organization wording. |
| app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemScreen.kt | Reverts overflow menu item text to move_to_organization. |
| app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditScreen.kt | Reverts overflow menu item text to move_to_organization. |
| app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/movetoorganization/VaultMoveToOrganizationScreenTest.kt | Updates assertions from “vault” to “Organization” text/content descriptions. |
| app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemScreenTest.kt | Updates overflow/menu assertions to “Move to Organization”. |
| app/src/test/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditScreenTest.kt | Updates overflow/menu assertions to “Move to Organization”. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/2026.7-rc59 #7221 +/- ##
=======================================================
+ Coverage 85.54% 86.08% +0.54%
=======================================================
Files 1051 891 -160
Lines 67658 64855 -2803
Branches 9797 9690 -107
=======================================================
- Hits 57875 55833 -2042
+ Misses 6287 5552 -735
+ Partials 3496 3470 -26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Cherry-pick of #7220 onto
release/2026.7-rc59.🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-41100
📔 Objective
The revert of the VFO-1 naming changes (#7195) squashed three separate PRs (#7183 Owner, #7189 Collections, #7192 Organization→Vault) into one commit. It correctly reverted the Owner and Collections wording everywhere, but missed every hunk belonging to the Organization→Vault rename — including two files (
VaultMoveToOrganizationContent.kt,VaultMoveToOrganizationEmpty.kt) that PR #7192 was the only one of the three to touch, so they never surfaced while resolving the other two.As a result, the app was still unconditionally showing "Move to vault" (menu item, app-bar title, dropdown label, description, empty-state) regardless of any feature flag — exactly what QA caught in this ticket on
rcbuilds.This restores
move_to_organization,move_to_org_desc, andno_orgs_to_list, points the affected screens/ViewModel back at them, and removes the leftovermove_to_vault/move_to_vault_desc/no_vaults_to_liststrings.📸 Screenshots