[BWA-99] feat: Add next TOTP code preview in Authenticator by SaintPatrck · Pull Request #6779 · bitwarden/android

SaintPatrck · 2026-04-09T20:14:58Z

🎟️ Tracking

https://bitwarden.atlassian.net/browse/BWA-99

📔 Objective

Add a "next TOTP code" preview to the Authenticator app. When a verification code is about to expire (< 10 seconds remaining), the upcoming code is displayed below the current one, allowing users to pre-read the next code without waiting for rotation.

Key behaviors:

Next code appears only when timeLeftSeconds < 10
Displayed in smaller, secondary-color text below the current code
Controlled by a "Show next code" toggle in Settings > Data (default: off)
Tapping an item still copies the current code

Implementation details:

Data layer: Second generateTotp() SDK call with currentTime + periodSeconds
Settings: Full DiskSource → Repository → ViewModel → Screen chain for the toggle
UI: Conditional rendering in VaultVerificationCodeItem composable
Wired through both ItemListingViewModel and ItemSearchViewModel

📸 Screenshots

Settings

Figma	Actual

Disclaimer: Figma includes the new Switch row, but other settings are outdated.

Upcoming code

Screen_recording_20260410_090617.mp4

Allow users to see the upcoming TOTP code when the current code is about to expire (< 10 seconds remaining). Controlled by a "Show next code" toggle in Settings > Data, defaulting to off.

github-actions · 2026-04-09T20:15:55Z

Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR adds a "next TOTP code" preview feature to the Authenticator app, displaying the upcoming verification code when fewer than 10 seconds remain before rotation. The implementation spans the full stack: data layer (second generateTotp() SDK call), settings persistence (DiskSource through Repository through ViewModel), and UI (animated visibility with AnimateNullableContentVisibility). All changes follow established codebase patterns, and test coverage is thorough across all layers including threshold boundary conditions, toggle filtering, and failure handling.

Code Review Details

No findings. The implementation is clean and well-structured:

Data layer gracefully handles next code generation failures via getOrNull()?.code
Settings chain follows the exact pattern used by existing settings (crash logging, screen capture)
UI filtering via takeIf keeps the data layer setting-unaware
Test coverage addresses all key scenarios: positive case, disabled setting, above-threshold, and SDK failure

codecov · 2026-04-09T20:19:56Z

Codecov Report

❌ Patch coverage is 97.87234% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.41%. Comparing base (62ceab5) to head (f7f816f).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...data/platform/repository/SettingsRepositoryImpl.kt	88.88%	0 Missing and 1 partial ⚠️
...tor/ui/platform/feature/settings/SettingsScreen.kt	93.75%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6779      +/-   ##
==========================================
+ Coverage   84.69%   85.41%   +0.71%     
==========================================
  Files         850      958     +108     
  Lines       59258    61011    +1753     
  Branches     8598     8662      +64     
==========================================
+ Hits        50188    52111    +1923     
+ Misses       6070     5876     -194     
- Partials     3000     3024      +24

Flag	Coverage Δ
app-data	`17.56% <0.00%> (+0.08%)`	⬆️
app-ui-auth-tools	`20.69% <0.00%> (+0.31%)`	⬆️
app-ui-platform	`15.87% <0.00%> (+0.58%)`	⬆️
app-ui-vault	`26.51% <0.00%> (+0.53%)`	⬆️
authenticator	`6.73% <97.87%> (+0.14%)`	⬆️
lib-core-network-bridge	`4.30% <0.00%> (+0.01%)`	⬆️
lib-data-ui	`1.04% <0.00%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

github-actions · 2026-04-09T20:21:48Z

Checkmarx One – Scan Summary & Details – c3d3354a-6757-4131-b42c-fe085f2f3af1

Great job! No new security vulnerabilities introduced in this pull request

Cover SettingsDiskSourceImpl, SettingsRepositoryImpl, SettingsViewModel toggle/update handlers, and TotpCodeManager next code failure fallback.

...rc/main/kotlin/com/bitwarden/authenticator/data/authenticator/manager/TotpCodeManagerImpl.kt

.../com/bitwarden/authenticator/ui/authenticator/feature/util/VerificationCodeItemExtensions.kt

david-livefront · 2026-04-09T21:20:14Z

...lin/com/bitwarden/authenticator/ui/platform/components/listitem/VaultVerificationCodeItem.kt

+            ) {
+                val formattedNextCode = nextAuthCode
+                    .chunked(size = 3) { "$it" }
+                    .joinToString(separator = " ")


Shouldn't this be:

val formattedNextCode = nextAuthCode .chunked(size = 3) { it.padEnd(length = 3, padChar = ' ') } .joinToString(separator = " ")

Ohh, I didn't realize this is for the content description.

Do we want it chunked at all?

...lin/com/bitwarden/authenticator/ui/platform/components/listitem/VaultVerificationCodeItem.kt

.../bitwarden/authenticator/ui/authenticator/feature/util/VerificationCodeItemExtensionsTest.kt

.../com/bitwarden/authenticator/ui/authenticator/feature/util/VerificationCodeItemExtensions.kt

david-livefront · 2026-04-10T14:08:03Z

.../kotlin/com/bitwarden/authenticator/data/authenticator/manager/model/VerificationCodeItem.kt

 * @property timeLeftSeconds The seconds remaining until a new code is required.
 * @property issueTime The time the verification code was issued.
 * @property id The cipher id of the item.
- * @property username The username associated with the item.


This was bugging me. Thank you for removing it. lol

david-livefront · 2026-04-10T14:52:53Z

ui/src/main/res/values/strings.xml

    <string name="allow_camera_access">Allow camera access</string>
    <string name="to_scan_your_card_we_need_access_to_your_camera">To scan your card, we’ll need access to your camera. You can change this anytime in your device settings.</string>
+    <string name="show_next_code">Show next code</string>
+    <string name="see_incoming_codes_in_the_list">See incoming codes in the list</string>


Should this say See upcoming codes in the list?

This matches Figma (added a screenshot). "Upcoming" does sound a little better though. @RishikaSG-28 thoughts?

david-livefront · 2026-04-10T14:53:14Z

ui/src/main/res/values/strings.xml

    <string name="to_scan_your_card_we_need_access_to_your_camera">To scan your card, we’ll need access to your camera. You can change this anytime in your device settings.</string>
+    <string name="show_next_code">Show next code</string>
+    <string name="see_incoming_codes_in_the_list">See incoming codes in the list</string>
+    <string name="next_code_x">Next code, %1$s</string>


Should this be Next code: %1$s?

Hmm. Probably. This was a last minute addition on Claude's part. @RishikaSG-28 thoughts?

[BWA-99] feat: Add next TOTP code preview in Authenticator

ab0d367

Allow users to see the upcoming TOTP code when the current code is about to expire (< 10 seconds remaining). Controlled by a "Show next code" toggle in Settings > Data, defaulting to off.

SaintPatrck added the ai-review-vnext Request a Claude code review using the vNext workflow label Apr 9, 2026

github-actions bot added app:password-manager Bitwarden Password Manager app context app:authenticator Bitwarden Authenticator app context t:feature Change Type - Feature Development labels Apr 9, 2026

Add test coverage for show next code setting

eb9cd20

Cover SettingsDiskSourceImpl, SettingsRepositoryImpl, SettingsViewModel toggle/update handlers, and TotpCodeManager next code failure fallback.

SaintPatrck marked this pull request as ready for review April 9, 2026 20:56

SaintPatrck requested review from a team and david-livefront as code owners April 9, 2026 20:56

SaintPatrck requested a review from RishikaSG-28 April 9, 2026 20:58

david-livefront reviewed Apr 9, 2026

View reviewed changes

...rc/main/kotlin/com/bitwarden/authenticator/data/authenticator/manager/TotpCodeManagerImpl.kt Outdated Show resolved Hide resolved

david-livefront reviewed Apr 9, 2026

View reviewed changes

.../com/bitwarden/authenticator/ui/authenticator/feature/util/VerificationCodeItemExtensions.kt Outdated Show resolved Hide resolved

david-livefront reviewed Apr 9, 2026

View reviewed changes

...lin/com/bitwarden/authenticator/ui/platform/components/listitem/VaultVerificationCodeItem.kt Outdated Show resolved Hide resolved

Address code review feedback

a32c994

claude bot reviewed Apr 10, 2026

View reviewed changes

.../bitwarden/authenticator/ui/authenticator/feature/util/VerificationCodeItemExtensionsTest.kt Show resolved Hide resolved

SaintPatrck force-pushed the bwa-99/next-totp-code-preview branch 2 times, most recently from e07396b to d2441b7 Compare April 10, 2026 13:04

claude bot reviewed Apr 10, 2026

View reviewed changes

.../com/bitwarden/authenticator/ui/authenticator/feature/util/VerificationCodeItemExtensions.kt Outdated Show resolved Hide resolved

RishikaSG-28 approved these changes Apr 10, 2026

View reviewed changes

Add tests for nextAuthCode threshold and toggle filtering

f7f816f

SaintPatrck force-pushed the bwa-99/next-totp-code-preview branch from d2441b7 to f7f816f Compare April 10, 2026 13:41

david-livefront reviewed Apr 10, 2026

View reviewed changes

Conversation

SaintPatrck commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎟️ Tracking

📔 Objective

📸 Screenshots

Settings

Upcoming code

Uh oh!

github-actions bot commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitwarden Claude Code Review

Uh oh!

codecov bot commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Great job! No new security vulnerabilities introduced in this pull request

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

SaintPatrck commented Apr 9, 2026 •

edited

Loading

github-actions bot commented Apr 9, 2026 •

edited

Loading

codecov bot commented Apr 9, 2026 •

edited

Loading

github-actions bot commented Apr 9, 2026 •

edited

Loading