Skip to content

PM-34840: bug: Allow related-origin passkey creation#6777

Open
david-livefront wants to merge 1 commit intomainfrom
PM-34840-related-origin-passkey-creation
Open

PM-34840: bug: Allow related-origin passkey creation#6777
david-livefront wants to merge 1 commit intomainfrom
PM-34840-related-origin-passkey-creation

Conversation

@david-livefront
Copy link
Copy Markdown
Collaborator

@david-livefront david-livefront commented Apr 9, 2026

🎟️ Tracking

PM-34840

📔 Objective

This PR pulls the requested origin for privileged apps (browsers) since they have already had their origin validated. This allows us to create passkeys from websites that use related-origins.

@david-livefront david-livefront requested a review from a team as a code owner April 9, 2026 14:59
@github-actions github-actions bot added app:password-manager Bitwarden Password Manager app context t:bug Change Type - Bug labels Apr 9, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.42%. Comparing base (7d9d65a) to head (2633d64).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...dentials/manager/BitwardenCredentialManagerImpl.kt 66.66% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6777      +/-   ##
==========================================
+ Coverage   85.39%   85.42%   +0.03%     
==========================================
  Files         916      871      -45     
  Lines       60355    60151     -204     
  Branches     8606     8635      +29     
==========================================
- Hits        51541    51385     -156     
+ Misses       5817     5751      -66     
- Partials     2997     3015      +18     
Flag Coverage Δ
app-data 17.17% <66.66%> (-0.04%) ⬇️
app-ui-auth-tools 20.59% <0.00%> (-0.06%) ⬇️
app-ui-platform 15.63% <0.00%> (-0.07%) ⬇️
app-ui-vault 26.48% <0.00%> (-0.05%) ⬇️
authenticator 6.55% <0.00%> (-0.03%) ⬇️
lib-core-network-bridge 4.28% <0.00%> (-0.01%) ⬇️
lib-data-ui 1.03% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026

Logo
Checkmarx One – Scan Summary & Details4afcc4c3-df87-47ea-8e1e-7e48e33e59ea

Great job! No new security vulnerabilities introduced in this pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app:password-manager Bitwarden Password Manager app context t:bug Change Type - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants