Skip to content

Prep work for AGP v9.0#6398

Closed
david-livefront wants to merge 1 commit intomainfrom
minor-gradle-updates
Closed

Prep work for AGP v9.0#6398
david-livefront wants to merge 1 commit intomainfrom
minor-gradle-updates

Conversation

@david-livefront
Copy link
Copy Markdown
Collaborator

🎟️ Tracking

N/A

📔 Objective

This PR makes some small updates to our gradle scripts in order to avoid deprecation that will be part of the AGP 9.0 update (coming soon).

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@david-livefront david-livefront requested a review from a team as a code owner January 22, 2026 20:40
@github-actions github-actions Bot added app:password-manager Bitwarden Password Manager app context app:authenticator Bitwarden Authenticator app context t:feature-tool Change Type - Internal tool feature or enhancement labels Jan 22, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 22, 2026

Logo
Checkmarx One – Scan Summary & Details2a25548a-a51d-4e8c-a9ba-4f8a8a8cf58e

Great job! No new security vulnerabilities introduced in this pull request

@david-livefront david-livefront added the ai-review Request a Claude code review label Jan 22, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.57%. Comparing base (acc3e24) to head (5412be6).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6398   +/-   ##
=======================================
  Coverage   85.57%   85.57%           
=======================================
  Files         764      764           
  Lines       55603    55603           
  Branches     8066     8066           
=======================================
  Hits        47581    47581           
  Misses       5245     5245           
  Partials     2777     2777           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@david-livefront david-livefront added the hold do not merge yet label Jan 22, 2026
@claude
Copy link
Copy Markdown
Contributor

claude Bot commented Jan 26, 2026

Claude finished @david-livefront's task in 1m 20s —— View job


Code Review: Approved

PR #6398: Prep work for AGP v9.0

Summary

This PR migrates all Gradle build configurations to use the new APIs required for Android Gradle Plugin 9.0 compatibility. The changes are well-structured and consistent across all 10 modified modules.

Changes Reviewed

Category Assessment
Security No concerns - build configuration only
Correctness Migration follows recommended AGP 9.0 patterns
Breaking Changes None - maintains identical build output behavior
Test Coverage N/A for build files; CI passing

Key Migrations

  1. SDK Version Declarations: Updated to block syntax with release() function

    • compileSdk = X to compileSdk { version = release(X) }
    • minSdk = X to minSdk { version = release(X) }
    • targetSdk = X to targetSdk { version = release(X) }
  2. Variant API Migration: Moved from deprecated internal APIs to public variant APIs

    • applicationVariants.all to androidComponents.onVariants
    • BaseVariantOutputImpl to VariantOutputImpl
    • Direct property assignment to Provider-based .get() / .set() methods
  3. Task Registration: Updated to lazy task matching pattern

    • tasks.getByName(...) to tasks.matching { ... }.forEach { ... }

Verification

  • All changes are consistent across modules
  • Import statements correctly reference com.android.build.api.variant.impl.VariantOutputImpl
  • Property access patterns properly use the Provider API
  • Checkmarx scan: No security vulnerabilities
  • CI: Passing

No issues identified.


Automated review by Claude Code

@david-livefront
Copy link
Copy Markdown
Collaborator Author

Closing, since this is not ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review app:authenticator Bitwarden Authenticator app context app:password-manager Bitwarden Password Manager app context hold do not merge yet t:feature-tool Change Type - Internal tool feature or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant