Switch from :track and :untrack events, which are unrecognized, to replica events which *are* recognized#128
Open
jesseshieh wants to merge 3 commits intobitwalker:masterfrom
Open
Conversation
added 3 commits
May 14, 2019 08:19
…d or if they should be calls instead of casts.
…re unused or if they should be calls instead of casts." This reverts commit a149655.
…plica events which *are* recognized.
balena
added a commit
to team-telnyx/swarm
that referenced
this pull request
May 11, 2020
…i-entropy execution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #127
I'm really not sure if this is correct or not, but the tests seem to pass and the "unrecognized cast" messages are now gone. I'm not sure whether it actually fixes anything or changes any behavior.