Fix mixed INT8 FakeTensor output metadata - #2044
Open
tandede wants to merge 1 commit into
Open
Conversation
tandede
marked this pull request as ready for review
August 19, 2026 11:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
subAwith the same shape and dtype contract as eager executionsubAtwo-dimensional when there are zero outlier columns, including whenoutlier_colsis omittedRoot cause
The fake implementation created
subAas a fresh one-dimensionalint64tensor. Eager execution instead returns the selected input columns, which are two-dimensional and inherit the input dtype. This causedtorch.library.opcheckto fail with mismatched output metadata. The eager no-outlier branch also returned a one-dimensional empty tensor, making the output rank depend on input data.Impact
The custom operation now has stable output metadata for FakeTensor and graph-capture consumers. The numerical mixed INT8 result is unchanged.
Tests
pytest -q tests/test_ops.py(649 passed, 69 skipped, 60 xfailed)Linear8bitLtcompile checks with threshold 6.0 on CPU and MPS (2 passed)pre-commit run --files bitsandbytes/_ops.py bitsandbytes/backends/default/ops.py tests/test_ops.py