Skip to content

Fix ci/cd issues of new Bswup (#12834) - #12835

Merged
msynk merged 1 commit into
bitfoundation:developfrom
msynk:12834-bswup-cicd-issues
Aug 6, 2026
Merged

Fix ci/cd issues of new Bswup (#12834)#12835
msynk merged 1 commit into
bitfoundation:developfrom
msynk:12834-bswup-cicd-issues

Conversation

@msynk

@msynk msynk commented Aug 5, 2026

Copy link
Copy Markdown
Member

closes #12834

Summary by CodeRabbit

  • Build & Release
    • Simplified build and package workflows by removing a redundant pre-build asset generation step.
    • Asset bundles are now generated as part of the standard build process across regular and prerelease builds.

@msynk
msynk requested a review from yasmoradi August 5, 2026 15:37
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bd08700b-3fd7-43dd-8a57-05507fb7be27

📥 Commits

Reviewing files that changed from the base of the PR and between 3e7157a and 4634595.

📒 Files selected for processing (3)
  • .github/workflows/bit.full.ci.yml
  • .github/workflows/nuget.org.yml
  • .github/workflows/prerelease.nuget.org.yml

Walkthrough

The CI, NuGet, and prerelease NuGet workflows remove the standalone Bswup CSS/JS generation step. Comments now state that the regular Bswup build generates the bundles.

Changes

Bswup workflow cleanup

Layer / File(s) Summary
Use regular Bswup build for bundles
.github/workflows/bit.full.ci.yml, .github/workflows/nuget.org.yml, .github/workflows/prerelease.nuget.org.yml
The workflows remove the standalone CSS/JS generation command and document bundle generation during the regular Bswup build.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Suggested reviewers: yasmoradi

Poem

A rabbit checks the build with care,
No extra bundle step waits there.
The regular build makes CSS bright,
And JavaScript takes flight.
Clean workflows hop along.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the CI/CD fix for the new Bswup component and references issue #12834.
Linked Issues check ✅ Passed The workflows remove the separate Bswup CSS/JS generation step required by issue #12834.
Out of Scope Changes check ✅ Passed All changes are limited to the three Bswup CI/CD workflows and support the linked issue objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@msynk
msynk merged commit c043685 into bitfoundation:develop Aug 6, 2026
1 check passed
@msynk
msynk deleted the 12834-bswup-cicd-issues branch August 6, 2026 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI/CD pipeline issues for the new Bswup

1 participant