Apply BitDropdown improvements (#12741) - #12745
Open
msynk wants to merge 22 commits into
Open
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughBitDropdown adds configurable search, selection, loading, empty-state, accessibility, keyboard, virtualization, styling, public API, test, and demo behavior. ChangesBitDropdown improvements
Estimated code review effort: 4 (Complex) | ~60 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Member
Author
|
@coderabbitai full-review |
|
✅ Action performedFull review finished. Your plan includes PR reviews subject to rate limits. More reviews will be available in 8 minutes. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (3)
src/BlazorUI/Bit.BlazorUI/Scripts/Dropdowns.ts (1)
183-185: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valuePage step is a hard-coded 10 items.
Extract it as a named constant next to
VIRTUALIZE_RENDER_FRAMES, or derive it from the visible window (clientHeight / itemHeight) so PageUp/PageDown match what the user actually sees.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/BlazorUI/Bit.BlazorUI/Scripts/Dropdowns.ts` around lines 183 - 185, Replace the hard-coded 10-item page step in the nextPage and prevPage branches with a named constant declared alongside VIRTUALIZE_RENDER_FRAMES, or calculate the step from the visible window using clientHeight and itemHeight. Reuse that step for both navigation directions while preserving the existing boundary clamping behavior.src/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.razor (1)
311-339: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winSelect-all button stays focusable/clickable when the dropdown is disabled or read-only.
The
bit-drp-idsclass is applied forIsEnabled is false, but the<button>itself has nodisabledattribute, so it remains tab-reachable and is also collected by_getItemsinDropdowns.ts.ReadOnlyisn't reflected at all. The click handler bails out, so this is presentation/keyboard-focus only.♻️ Proposed change
<button `@onclick`="HandleOnSelectAllClick" type="button" role="checkbox" + disabled="@(IsEnabled is false || ReadOnly)" + aria-disabled="@(IsEnabled is false || ReadOnly)" style="`@Styles`?.SelectAllButton"🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.razor` around lines 311 - 339, Update the select-all button rendered in the MultiSelect/ShowSelectAll block to be non-focusable and non-clickable when the dropdown is disabled or read-only. Reflect both IsEnabled and ReadOnly on the button’s disabled state so _getItems excludes it, while preserving its current enabled behavior and styling.src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownCustomDemo.razor (1)
707-707: 🚀 Performance & Scalability | 🔵 Trivial | 💤 Low valueConsider
PreventRenderForMcpClienton the Virtualization example for consistency.The equivalent Virtualization example in
_BitDropdownItemDemo.razor(line 685) setsPreventRenderForMcpClient, while this one renders two 10k-item collections plus fourItemsProvider-backed dropdowns.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownCustomDemo.razor` at line 707, Add PreventRenderForMcpClient to the Virtualization DemoExample identified by Id "example20" and title "Virtualization", matching the equivalent configuration in _BitDropdownItemDemo.razor.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.razor`:
- Around line 341-346: Update the listbox markup in BitDropdown to conditionally
emit aria-labelledby using GetDropdownAriaLabelledby(), matching the trigger
behavior. Ensure no aria-labelledby attribute is rendered when neither
LabelTemplate nor Label creates the referenced label element.
In `@src/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.razor.cs`:
- Around line 1448-1453: Update the callout keydown handling used by
HandleOnCalloutKeyDown and its Dropdowns.ts listener to prevent Tab’s default
browser focus movement, then close the callout and deliberately focus the
appropriate next or previous tabbable element based on Shift+Tab. Preserve
reachability of header/footer template controls and the search box in forward
tab order, rather than always refocusing _dropdownWrapperRef.
In
`@src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownCustomDemo.razor.samples.cs`:
- Around line 1742-1756: Update the sample Product class used by
example22CsharpCode and the corresponding class in the additional sample so it
declares the CssClass and CssStyle properties referenced by the nameSelectors
configuration; keep the existing selectors unchanged and ensure the copied
examples compile.
---
Nitpick comments:
In `@src/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.razor`:
- Around line 311-339: Update the select-all button rendered in the
MultiSelect/ShowSelectAll block to be non-focusable and non-clickable when the
dropdown is disabled or read-only. Reflect both IsEnabled and ReadOnly on the
button’s disabled state so _getItems excludes it, while preserving its current
enabled behavior and styling.
In `@src/BlazorUI/Bit.BlazorUI/Scripts/Dropdowns.ts`:
- Around line 183-185: Replace the hard-coded 10-item page step in the nextPage
and prevPage branches with a named constant declared alongside
VIRTUALIZE_RENDER_FRAMES, or calculate the step from the visible window using
clientHeight and itemHeight. Reuse that step for both navigation directions
while preserving the existing boundary clamping behavior.
In
`@src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownCustomDemo.razor`:
- Line 707: Add PreventRenderForMcpClient to the Virtualization DemoExample
identified by Id "example20" and title "Virtualization", matching the equivalent
configuration in _BitDropdownItemDemo.razor.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 669d003b-b8c4-424c-b3d5-d5e8679f3ba6
📒 Files selected for processing (19)
src/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.razorsrc/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.razor.cssrc/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.scsssrc/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdownClassStyles.cssrc/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/_BitDropdownItem.razorsrc/BlazorUI/Bit.BlazorUI/Extensions/JsInterop/DropdownsJsRuntimeExtensions.cssrc/BlazorUI/Bit.BlazorUI/Scripts/Dropdowns.tssrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/BitDropdownDemo.razorsrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/BitDropdownDemo.razor.cssrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/BitDropdownDemo.razor.scsssrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownCustomDemo.razorsrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownCustomDemo.razor.cssrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownCustomDemo.razor.samples.cssrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownItemDemo.razorsrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownItemDemo.razor.cssrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownItemDemo.razor.samples.cssrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownOptionDemo.razorsrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownOptionDemo.razor.cssrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownOptionDemo.razor.samples.cs
….com/msynk/bitframework into 12741-blazorui-dropdown-improvements
Member
Author
|
@coderabbitai full-review |
|
✅ Action performedFull review finished. |
There was a problem hiding this comment.
Actionable comments posted: 5
🧹 Nitpick comments (1)
src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownCustomDemo.razor.samples.cs (1)
561-582: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winSeveral new C# samples omit members their Razor sample references.
example9RazorCodeusescomboBoxCustomsandcomboBoxNameSelectors(lines 554-559), butexample9CsharpCodedefines neither, nor theProductclass. Same gap inexample16CsharpCode(razor usesnameSelectors,comboBoxCustoms,comboBoxNameSelectors),example22CsharpCode(razor usesnameSelectors) andexample26CsharpCode(noProduct). Sibling samples (example18,example19,example21) include the full boilerplate — worth aligning so the snippets are copy-pasteable.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownCustomDemo.razor.samples.cs` around lines 561 - 582, Complete the C# snippets in example9CsharpCode, example16CsharpCode, example22CsharpCode, and example26CsharpCode with every Product, collection, and selector member referenced by their corresponding Razor snippets, including comboBoxCustoms, comboBoxNameSelectors, nameSelectors, and Product as applicable. Align their declarations with the complete boilerplate used by example18, example19, and example21 so each sample is independently copy-pasteable.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.razor.cs`:
- Around line 860-883: Add a _positionsSelectionVersion backing field alongside
the existing position-cache fields, and include _selectionVersion in the cache
invalidation condition and cache-key updates within GetItemPositions(). This
must rebuild positions after selection changes, especially when
HideSelectedItems is enabled, while preserving the existing SearchText and
_optionsVersion cache behavior.
In `@src/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.scss`:
- Around line 1002-1008: Update the small dropdown styles in .bit-drp-sm so the
.bit-drp-pre/.bit-drp-suf height uses var(--bit-drp-h) instead of the fixed
spacing(3.75) value, allowing adorned controls to retain the configured small
height.
In
`@src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownItemDemo.razor.samples.cs`:
- Around line 841-847: Update the example16 sample’s backing declarations to
include the comboBoxItems list required by its BitDropdown Items binding,
matching the existing declaration pattern used in examples 9, 10, 14, 15, and
17. Ensure both the primary block and the additionally referenced range compile
without changing the sample’s other behavior.
In
`@src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownOptionDemo.razor.samples.cs`:
- Around line 1401-1454: Update the example22 C# sample code associated with
example22RazorCode to declare and initialize the basicItems collection before it
is used by the Razor loops and LoadDelayedItems. Keep the existing
isLoadingItems and delayedItems declarations unchanged so the sample remains
self-contained.
- Around line 1102-1112: Update the example16 sample code, including the related
example16CsharpCode block, to declare and initialize the comboBoxItems list
before the BitDropdown markup iterates it. Match the existing comboBoxItems
declaration pattern used by examples 14, 15, and 17 while preserving the
existing basicItems declaration and AutoClearSearch sample behavior.
---
Nitpick comments:
In
`@src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownCustomDemo.razor.samples.cs`:
- Around line 561-582: Complete the C# snippets in example9CsharpCode,
example16CsharpCode, example22CsharpCode, and example26CsharpCode with every
Product, collection, and selector member referenced by their corresponding Razor
snippets, including comboBoxCustoms, comboBoxNameSelectors, nameSelectors, and
Product as applicable. Align their declarations with the complete boilerplate
used by example18, example19, and example21 so each sample is independently
copy-pasteable.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: b79a8b8a-4de8-432f-a479-7002c7295fb6
📒 Files selected for processing (21)
src/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.razorsrc/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.razor.cssrc/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.scsssrc/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdownClassStyles.cssrc/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdownSearchMode.cssrc/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/_BitDropdownItem.razorsrc/BlazorUI/Bit.BlazorUI/Extensions/JsInterop/DropdownsJsRuntimeExtensions.cssrc/BlazorUI/Bit.BlazorUI/Scripts/Dropdowns.tssrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/BitDropdownDemo.razorsrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/BitDropdownDemo.razor.cssrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/BitDropdownDemo.razor.scsssrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownCustomDemo.razorsrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownCustomDemo.razor.cssrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownCustomDemo.razor.samples.cssrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownItemDemo.razorsrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownItemDemo.razor.cssrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownItemDemo.razor.samples.cssrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownOptionDemo.razorsrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownOptionDemo.razor.cssrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownOptionDemo.razor.samples.cssrc/BlazorUI/Tests/Bit.BlazorUI.Tests/Components/Inputs/Dropdown/BitDropdownTests.cs
Member
Author
|
@coderabbitai full-review |
|
✅ Action performedFull review finished. |
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Nitpick comments (3)
src/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdownSearchMode.cs (1)
20-23: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win
Equalsas a member name hidesobject.Equalson the type.
BitDropdownSearchMode.Equals(a, b)no longer resolves to the staticobject.Equalsoverload, and the name reads oddly in an enum of match modes. Renaming later would be a breaking public API change, so considerExactMatch(orExact) now.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdownSearchMode.cs` around lines 20 - 23, Rename the BitDropdownSearchMode enum member Equals to a non-conflicting match-mode name such as ExactMatch, and update all references to the member accordingly. Preserve the existing exact text matching behavior while avoiding shadowing object.Equals and establishing the corrected public API name now.src/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.razor.cs (1)
1744-1750: 🩺 Stability & Availability | 🔵 Trivial | 💤 Low valueFire-and-forget
ClearComboBoxInputnow reachesVirtualize.RefreshDataAsync.
ClearComboBoxInputawaitsSearchVirtualized(), so this discarded task performs JS/render work outside the caller's flow; any exception (e.g. anObjectDisposedExceptionwhen the component is torn down while the callout closes) is unobservable. Consider awaiting these from the caller ofOnSetIsOpenor at least logging the faulted task.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.razor.cs` around lines 1744 - 1750, Update the OnSetIsOpen flow to await ClearComboBoxInput instead of discarding its task, allowing the SearchVirtualized and Virtualize.RefreshDataAsync work and exceptions to remain in the caller’s async flow. Preserve the existing ordering so the combo input is cleared before invoking OnOpen or OnClose.src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownCustomDemo.razor.samples.cs (1)
626-628: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueCombo sample
TextSetterlambdas declare a nullable first parameter.BitDropdownNameSelectors.TextSetterisAction<string, TItem>?and the real code-behind uses(string text, Product item); the samples all usestring?, so copied code warns on nullability.
src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownCustomDemo.razor.samples.cs#L626-L628: change(string? text, Product item)to(string text, Product item)inexample9CsharpCode..../_BitDropdownCustomDemo.razor.samples.cs#L1153-L1155: same change inexample14CsharpCode..../_BitDropdownCustomDemo.razor.samples.cs#L1222-L1224: same change inexample15CsharpCode..../_BitDropdownCustomDemo.razor.samples.cs#L1342-L1344: same change inexample16CsharpCode..../_BitDropdownCustomDemo.razor.samples.cs#L1431-L1433: same change inexample17CsharpCode.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownCustomDemo.razor.samples.cs` around lines 626 - 628, Update the TextSetter lambda parameter type from nullable string? to non-nullable string in example9CsharpCode at src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownCustomDemo.razor.samples.cs:626-628, and apply the same change in example14CsharpCode at :1153-1155, example15CsharpCode at :1222-1224, example16CsharpCode at :1342-1344, and example17CsharpCode at :1431-1433. Keep the Product item parameter and setter behavior unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.razor`:
- Around line 466-473: Keep the live-region container associated with
GetSearchResultsText permanently mounted in the dropdown markup, and
conditionally vary or clear only its text based on HasSearchText and IsLoading.
Preserve the existing polite, atomic status semantics while ensuring the element
remains in the accessibility tree before search-result announcements occur.
In `@src/BlazorUI/Bit.BlazorUI/Scripts/Dropdowns.ts`:
- Around line 116-122: Update the visibility filter in BitDropdowns._getItems to
remove the offsetParent check, which excludes valid position-fixed dropdown
items. Replace it with a robust visibility check using checkVisibility() or
nonzero getBoundingClientRect() dimensions while preserving the existing
disabled and excluded-container filters.
- Around line 85-170: Serialize virtualized focus operations per callout by
adding a generation token associated with each callout and incrementing it at
the start of focusItem. Capture the token before awaiting _scrollFor, then abort
the stale invocation if the token changes after the await, preventing outdated
calls from applying interleaved items, scrolling, or focus results.
In
`@src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownOptionDemo.razor.samples.cs`:
- Around line 488-512: Update the example9 sample declarations to include the
comboBoxItems collection referenced by the “Highlight in the ComboBox” markup,
matching the equivalent declarations in _BitDropdownItemDemo.razor.samples.cs
while retaining basicItems for the existing dropdown examples.
---
Nitpick comments:
In `@src/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.razor.cs`:
- Around line 1744-1750: Update the OnSetIsOpen flow to await ClearComboBoxInput
instead of discarding its task, allowing the SearchVirtualized and
Virtualize.RefreshDataAsync work and exceptions to remain in the caller’s async
flow. Preserve the existing ordering so the combo input is cleared before
invoking OnOpen or OnClose.
In
`@src/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdownSearchMode.cs`:
- Around line 20-23: Rename the BitDropdownSearchMode enum member Equals to a
non-conflicting match-mode name such as ExactMatch, and update all references to
the member accordingly. Preserve the existing exact text matching behavior while
avoiding shadowing object.Equals and establishing the corrected public API name
now.
In
`@src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownCustomDemo.razor.samples.cs`:
- Around line 626-628: Update the TextSetter lambda parameter type from nullable
string? to non-nullable string in example9CsharpCode at
src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownCustomDemo.razor.samples.cs:626-628,
and apply the same change in example14CsharpCode at :1153-1155,
example15CsharpCode at :1222-1224, example16CsharpCode at :1342-1344, and
example17CsharpCode at :1431-1433. Keep the Product item parameter and setter
behavior unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 91a1b8ab-ff01-4c43-b4d6-289c5d006623
📒 Files selected for processing (21)
src/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.razorsrc/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.razor.cssrc/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.scsssrc/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdownClassStyles.cssrc/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdownSearchMode.cssrc/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/_BitDropdownItem.razorsrc/BlazorUI/Bit.BlazorUI/Extensions/JsInterop/DropdownsJsRuntimeExtensions.cssrc/BlazorUI/Bit.BlazorUI/Scripts/Dropdowns.tssrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/BitDropdownDemo.razorsrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/BitDropdownDemo.razor.cssrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/BitDropdownDemo.razor.scsssrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownCustomDemo.razorsrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownCustomDemo.razor.cssrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownCustomDemo.razor.samples.cssrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownItemDemo.razorsrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownItemDemo.razor.cssrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownItemDemo.razor.samples.cssrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownOptionDemo.razorsrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownOptionDemo.razor.cssrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownOptionDemo.razor.samples.cssrc/BlazorUI/Tests/Bit.BlazorUI.Tests/Components/Inputs/Dropdown/BitDropdownTests.cs
Member
Author
|
@coderabbitai full-review |
|
✅ Action performedFull review finished. |
…into 12741-blazorui-dropdown-improvements
There was a problem hiding this comment.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownCustomDemo.razor.samples.cs (1)
659-702: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
example10CsharpCodeis missingcomboBoxNameSelectors.The razor snippet (line 658) binds
NameSelectors="comboBoxNameSelectors", but the C# sample only declaresnameSelectors, plus noProductclass is defined here either. Copying this example won't compile. Other combo samples (e.g.example9CsharpCode) declare both.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownCustomDemo.razor.samples.cs` around lines 659 - 702, Update the example10CsharpCode sample to declare comboBoxNameSelectors alongside nameSelectors, matching the NameSelectors binding in the razor snippet and the pattern used by example9CsharpCode. Ensure the sample also includes the Product model declaration required by these selector definitions so the copied example compiles.
🧹 Nitpick comments (3)
src/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.razor.cs (1)
844-856: 🎯 Functional Correctness | 🔵 Trivial | 💤 Low value
IsMaxSelectedItemsReachedreadsValues, which can lag_selectedItemsin unbound scenarios.
AddOrRemoveSelectedItemassigns throughAssignValues, soValuesis normally in sync, but dynamically added combo items are pushed straight into_selectedItems. Consider deriving the count from_selectedItemsfor consistency with the chips/summary counters (GetDisplayedItemsCount).🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.razor.cs` around lines 844 - 856, Update IsMaxSelectedItemsReached and its IsValuesCountAtLeast usage to derive the selected-item count from _selectedItems rather than Values, matching GetDisplayedItemsCount and keeping the limit check consistent for dynamically added combo items.src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownOptionDemo.razor (1)
1012-1022: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueMulti-select without any
Values/DefaultValuesbinding, unlike the sibling examples.Every other new multi-select sample here sets
DefaultValues(e.g.HideSelectedItemsat Line 1029,Item check iconat Line 1534), and the item-demo counterpart usesDefaultValues="@(Array.Empty<string>())"for this sameAutoClearSearchexample. Line 1506 (Chips remove icon (external)) has the same gap. Worth aligning so the demos start from a defined selection state.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownOptionDemo.razor` around lines 1012 - 1022, Update the AutoClearSearch BitDropdown sample to bind DefaultValues to an empty string array, matching the item-demo counterpart and sibling multi-select examples. Also apply the same explicit empty DefaultValues binding to the “Chips remove icon (external)” sample, while preserving their existing selection behavior.src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownItemDemo.razor.samples.cs (1)
1042-1047: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueEmpty/no-results/loading sample templates reference an undefined
custom-drp-emptyclass. The new templates reuseclass="custom-drp custom-drp-empty", but the only embedded<style>block in either samples file (example12) defines.custom-drpplus-lbl/-txt/-ph/-item/-header— never-empty. Copied as-is, the snippets render unstyled.
src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownItemDemo.razor.samples.cs#L1042-L1047: add a small<style>block defining.custom-drp-emptytoexample21RazorCode(and reuse it inexample22RazorCodeat Line 1114), or drop the class.src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownOptionDemo.razor.samples.cs#L1362-L1367: apply the same fix toexample21RazorCodeandexample22RazorCode(Line 1458).🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownItemDemo.razor.samples.cs` around lines 1042 - 1047, Define styling for the custom-drp-empty class, or remove that class, so the empty/no-results/loading templates render correctly. In src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownItemDemo.razor.samples.cs:1042-1047, update example21RazorCode and reuse the fix in example22RazorCode around line 1114; apply the same change in _BitDropdownOptionDemo.razor.samples.cs:1362-1367 for example21RazorCode and around line 1458 for example22RazorCode.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.razor.cs`:
- Around line 2110-2131: Invalidate the searched and display caches whenever the
ItemsProvider replaces _lastShownItems in the provider request flow. Update the
state after assigning providerResult.Items so _searchedItems, _displayItems, and
_itemPositions cannot be reused for the previous window, while preserving the
existing StateHasChanged and result-return behavior.
In
`@src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownCustomDemo.razor`:
- Around line 301-303: Update the dropdown search-mode prose to use the valid
BitDropdownSearchMode member ExactMatch instead of Equals in
_BitDropdownCustomDemo.razor lines 301-303 and _BitDropdownItemDemo.razor lines
299-301; leave the remaining mode descriptions unchanged.
In
`@src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/BitDropdownDemo.razor.cs`:
- Around line 428-433: Update the OnDynamicAdd entry in the component reference
table to use EventCallback<TItem> instead of EventCallback<string>, matching
BitDropdown’s declaration and the Product callback usage in the demos.
---
Outside diff comments:
In
`@src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownCustomDemo.razor.samples.cs`:
- Around line 659-702: Update the example10CsharpCode sample to declare
comboBoxNameSelectors alongside nameSelectors, matching the NameSelectors
binding in the razor snippet and the pattern used by example9CsharpCode. Ensure
the sample also includes the Product model declaration required by these
selector definitions so the copied example compiles.
---
Nitpick comments:
In `@src/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.razor.cs`:
- Around line 844-856: Update IsMaxSelectedItemsReached and its
IsValuesCountAtLeast usage to derive the selected-item count from _selectedItems
rather than Values, matching GetDisplayedItemsCount and keeping the limit check
consistent for dynamically added combo items.
In
`@src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownItemDemo.razor.samples.cs`:
- Around line 1042-1047: Define styling for the custom-drp-empty class, or
remove that class, so the empty/no-results/loading templates render correctly.
In
src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownItemDemo.razor.samples.cs:1042-1047,
update example21RazorCode and reuse the fix in example22RazorCode around line
1114; apply the same change in _BitDropdownOptionDemo.razor.samples.cs:1362-1367
for example21RazorCode and around line 1458 for example22RazorCode.
In
`@src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownOptionDemo.razor`:
- Around line 1012-1022: Update the AutoClearSearch BitDropdown sample to bind
DefaultValues to an empty string array, matching the item-demo counterpart and
sibling multi-select examples. Also apply the same explicit empty DefaultValues
binding to the “Chips remove icon (external)” sample, while preserving their
existing selection behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: a25ae613-18cf-495e-a6cb-07aa77252c6f
📒 Files selected for processing (21)
src/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.razorsrc/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.razor.cssrc/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.scsssrc/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdownClassStyles.cssrc/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdownSearchMode.cssrc/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/_BitDropdownItem.razorsrc/BlazorUI/Bit.BlazorUI/Extensions/JsInterop/DropdownsJsRuntimeExtensions.cssrc/BlazorUI/Bit.BlazorUI/Scripts/Dropdowns.tssrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/BitDropdownDemo.razorsrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/BitDropdownDemo.razor.cssrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/BitDropdownDemo.razor.scsssrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownCustomDemo.razorsrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownCustomDemo.razor.cssrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownCustomDemo.razor.samples.cssrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownItemDemo.razorsrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownItemDemo.razor.cssrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownItemDemo.razor.samples.cssrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownOptionDemo.razorsrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownOptionDemo.razor.cssrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownOptionDemo.razor.samples.cssrc/BlazorUI/Tests/Bit.BlazorUI.Tests/Components/Inputs/Dropdown/BitDropdownTests.cs
Member
Author
|
@coderabbitai full-review |
|
✅ Action performedFull review finished. Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 11 seconds. |
…into 12741-blazorui-dropdown-improvements
…into 12741-blazorui-dropdown-improvements
…into 12741-blazorui-dropdown-improvements
Member
Author
|
@coderabbitai full-review |
|
✅ Action performedFull review finished. |
There was a problem hiding this comment.
Actionable comments posted: 4
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.razor (1)
53-62: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winKeep options registered when
IsLoadingchanges.When
IsLoadingfalls tofalsewhileVirtualizeisfalse, the option markup is moved from the hidden wrapper to the normal dropdown wrapper.BitDropdownOptionregisters inOnInitializedAsyncand unregisters fromDispose, so moving the options creates new component instances while the old instances are disposed. If disposal runs after the new instances register, the dropdown removes the items fromItemsand_selectedItems, leaving an empty callout selection until the next parameter set. Add a test that starts withIsLoadingtrue, the options selected, and then flipsIsLoadingto false.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.razor` around lines 53 - 62, The conditional rendering in BitDropdown must keep the same option component instances mounted when IsLoading changes, including when Virtualize is false, instead of moving Options or ChildContent between the hidden and normal wrappers. Adjust the BitDropdown render structure so options remain registered throughout loading transitions, and add a regression test covering an initially loading dropdown with selected options that then sets IsLoading to false while preserving the selection.
🧹 Nitpick comments (4)
src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownCustomDemo.razor (1)
88-94: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueTwo multi-select examples set
DefaultValueinstead ofDefaultValues.
DefaultValueis the single-select initializer, andDefaultValuesis the multi-select one. Both dropdowns declareMultiSelect, so the value passed toDefaultValuehas no effect on the initial selection. Both examples are copied into user projects, so they teach the wrong parameter for the mode.If the parameter is only present so that Razor can infer
TValue, useDefaultValuesfor that purpose instead. It infers the same type and matches the mode.♻️ Proposed refactor
<BitDropdown Label="StickyHeaders" StickyHeaders MultiSelect Items="GetGroupedCustoms()" NameSelectors="nameSelectors" - DefaultValue="`@string.Empty`" + DefaultValues="@(Array.Empty<string>())" Placeholder="Select items" /><BitDropdown MultiSelect ShowSelectAll ShowSearchBox SelectAllText="Select all of them" Items="GetBasicCustoms()" NameSelectors="nameSelectors" Placeholder="Select items" - DefaultValue="`@string.Empty`" + DefaultValues="@(Array.Empty<string>())" SearchBoxPlaceholder="Search items" Label="Custom text & search" />Also applies to: 993-1002
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownCustomDemo.razor` around lines 88 - 94, Update both multi-select dropdown examples in _BitDropdownCustomDemo, including the StickyHeaders example and the additional occurrence, to use DefaultValues instead of DefaultValue. Preserve the existing empty-string initializer so Razor type inference remains intact while matching the MultiSelect parameter.src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/BitDropdownDemo.razor.cs (1)
1814-1871: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueThe
Typecolumn ofcomponentPublicMembersnow mixes bare types and full signatures.The new entries give complete signatures, for example
Task SelectItem(TItem? item)andValueTask FocusAsync(bool preventScroll = false). The neighboring entriesFocusComboInputAsync(Line 1857) andFocusSearchInputAsync(Line 1869) still give onlyValueTask. The reference table then presents two formats for the same kind of member. Use one format for every method entry.♻️ Proposed refactor
new() { Name = "FocusComboInputAsync", - Type = "ValueTask", + Type = "ValueTask FocusComboInputAsync(bool preventScroll = false)", Description = "Gives focus to the combo input element.", },🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/BitDropdownDemo.razor.cs` around lines 1814 - 1871, Update the Type values for the method entries FocusComboInputAsync and FocusSearchInputAsync in componentPublicMembers to use complete method signatures, matching SelectItem, UnselectItem, RefreshItemsAsync, AssignIsOpen, and FocusAsync. Keep property entries such as ComboInputElement and SearchInputElement as bare types.src/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.scss (1)
1020-1038: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueThe size modifiers depend on source order to beat the base declarations.
.bit-drp(Line 23) and.bit-drp-cal(Line 691) both includedrp-size-medium, and the size modifiers have the same specificity (one class). The override works only because.bit-drp-smand.bit-drp-lgappear later in the file. A future re-order of this stylesheet, or a build step that groups rules, silently restores the medium values. Bind the modifiers to the element they modify to make the override specificity-based instead of order-based.
.bit-drp-mdis then also redundant, because the base rule already supplies the medium values.♻️ Proposed refactor
-.bit-drp-sm { +.bit-drp.bit-drp-sm, +.bit-drp-cal.bit-drp-sm { --bit-drp-fs: #{spacing(1.5)}; --bit-drp-h: #{spacing(3.25)}; --bit-drp-lh: #{spacing(3)}; --bit-drp-itm-h: #{spacing(3.75)}; --bit-drp-itm-fs: #{spacing(1.625)}; } -.bit-drp-md { - `@include` drp-size-medium; -} - -.bit-drp-lg { +.bit-drp.bit-drp-lg, +.bit-drp-cal.bit-drp-lg { --bit-drp-fs: #{spacing(2)}; --bit-drp-h: #{spacing(5)}; --bit-drp-lh: #{spacing(4.75)}; --bit-drp-itm-h: #{spacing(5.5)}; --bit-drp-itm-fs: #{spacing(2.125)}; }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.scss` around lines 1020 - 1038, Update the dropdown size modifiers `.bit-drp-sm` and `.bit-drp-lg` so their selectors are bound to the `.bit-drp` or `.bit-drp-cal` element they modify, giving them higher specificity than the `drp-size-medium` declarations. Remove the redundant `.bit-drp-md` rule because the base medium sizing already provides those values.src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownCustomDemo.razor.samples.cs (1)
2275-2310: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueDeclare the
Productclass inexample26CsharpCode.The
nameSelectorsinitializer in this sample readsc.Label,c.Key,c.Payload,c.Disabled,c.Visible,c.Type,c.Text,c.Titleandc.Value, but the sample never declaresProduct. A reader who copies this snippet cannot compile it. Every other sample in this file that uses the full selector set declares the class inline (for example lines 57-68).The same gap exists in
example7CsharpCode(lines 407-428).📝 Proposed fix
private readonly string example26CsharpCode = @" +public class Product +{ + public string? Label { get; set; } + public string? Key { get; set; } + public object? Payload { get; set; } + public bool Disabled { get; set; } + public bool Visible { get; set; } = true; + public BitDropdownItemType Type { get; set; } = BitDropdownItemType.Normal; + public string? Text { get; set; } + public string? Title { get; set; } + public string? Value { get; set; } +} + private List<Product> comboBoxCustoms = new()🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownCustomDemo.razor.samples.cs` around lines 2275 - 2310, Declare the Product class inline within both example26CsharpCode and example7CsharpCode, including the properties required by their BitDropdownNameSelectors initializers: Label, Key, Payload, Disabled, Visible, Type, Text, Title, and Value. Match the inline Product declaration pattern used by the other samples in the file so each copied snippet compiles independently.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.razor.cs`:
- Around line 2963-2976: Gate the AutoSelectFirstMatch branch in the surrounding
selection method on an active search term, such as non-null, non-empty
SearchText, before calling GetDisplayItems(). Preserve the existing match
filtering and AddOrRemoveSelectedItem behavior once a search is active, and
avoid selecting any item while the typed text is shorter than MinSearchLength.
In
`@src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownCustomDemo.razor`:
- Around line 69-79: Update the screen-reader announcement in the Grouping prose
of the dropdown demo to match the rendered GetGroupedCustoms() data, using
Broccoli’s seventh-of-eighteen position, or remove the specific position and
count while preserving the grouping explanation.
In
`@src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownOptionDemo.razor.samples.cs`:
- Around line 110-139: Update the first “Grouped options” BitDropdown in
example2RazorCode to render its options by iterating groupedItems, matching the
rendered demo and the existing StickyHeaders dropdown below it. Remove the
shortened inline option list while preserving the dropdown’s current properties
and option mapping.
In
`@src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/BitDropdownDemo.razor.cs`:
- Around line 252-263: Update the Type declaration for the FindItemFunction
entry to use a nullable TItem return value: Func<ICollection<TItem>, string,
TItem?>?. Keep the surrounding description and ExistsSelectedItemFunction entry
unchanged.
---
Outside diff comments:
In `@src/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.razor`:
- Around line 53-62: The conditional rendering in BitDropdown must keep the same
option component instances mounted when IsLoading changes, including when
Virtualize is false, instead of moving Options or ChildContent between the
hidden and normal wrappers. Adjust the BitDropdown render structure so options
remain registered throughout loading transitions, and add a regression test
covering an initially loading dropdown with selected options that then sets
IsLoading to false while preserving the selection.
---
Nitpick comments:
In `@src/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.scss`:
- Around line 1020-1038: Update the dropdown size modifiers `.bit-drp-sm` and
`.bit-drp-lg` so their selectors are bound to the `.bit-drp` or `.bit-drp-cal`
element they modify, giving them higher specificity than the `drp-size-medium`
declarations. Remove the redundant `.bit-drp-md` rule because the base medium
sizing already provides those values.
In
`@src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownCustomDemo.razor`:
- Around line 88-94: Update both multi-select dropdown examples in
_BitDropdownCustomDemo, including the StickyHeaders example and the additional
occurrence, to use DefaultValues instead of DefaultValue. Preserve the existing
empty-string initializer so Razor type inference remains intact while matching
the MultiSelect parameter.
In
`@src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownCustomDemo.razor.samples.cs`:
- Around line 2275-2310: Declare the Product class inline within both
example26CsharpCode and example7CsharpCode, including the properties required by
their BitDropdownNameSelectors initializers: Label, Key, Payload, Disabled,
Visible, Type, Text, Title, and Value. Match the inline Product declaration
pattern used by the other samples in the file so each copied snippet compiles
independently.
In
`@src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/BitDropdownDemo.razor.cs`:
- Around line 1814-1871: Update the Type values for the method entries
FocusComboInputAsync and FocusSearchInputAsync in componentPublicMembers to use
complete method signatures, matching SelectItem, UnselectItem,
RefreshItemsAsync, AssignIsOpen, and FocusAsync. Keep property entries such as
ComboInputElement and SearchInputElement as bare types.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 0990fc2d-1828-4dea-ae47-8f7e1b143c04
📒 Files selected for processing (22)
src/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.razorsrc/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.razor.cssrc/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.scsssrc/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdownClassStyles.cssrc/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdownOption.cssrc/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdownSearchMode.cssrc/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/_BitDropdownItem.razorsrc/BlazorUI/Bit.BlazorUI/Extensions/JsInterop/DropdownsJsRuntimeExtensions.cssrc/BlazorUI/Bit.BlazorUI/Scripts/Dropdowns.tssrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/BitDropdownDemo.razorsrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/BitDropdownDemo.razor.cssrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/BitDropdownDemo.razor.scsssrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownCustomDemo.razorsrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownCustomDemo.razor.cssrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownCustomDemo.razor.samples.cssrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownItemDemo.razorsrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownItemDemo.razor.cssrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownItemDemo.razor.samples.cssrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownOptionDemo.razorsrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownOptionDemo.razor.cssrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownOptionDemo.razor.samples.cssrc/BlazorUI/Tests/Bit.BlazorUI.Tests/Components/Inputs/Dropdown/BitDropdownTests.cs
Member
Author
|
@coderabbitai full-review |
|
✅ Action performedFull review finished. |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (9)
src/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.razor.cs (2)
2355-2400: 🚀 Performance & Scalability | 🔵 Trivial | ⚡ Quick winDiacritic folding runs per item on every match and highlight.
IsItemTextMatchandGetHighlightIndexcallRemoveDiacriticsfor each item text. WithSearchIgnoreDiacriticsandHighlightSearchboth enabled, each item text is folded twice per search pass, and each fold allocates aStringBuilderplus a normalized string per character. Cache the folded item text (for example in aDictionary<string, string>reset with_optionsVersion) to keep long lists responsive.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.razor.cs` around lines 2355 - 2400, Cache diacritic-folded item text in the dropdown, keyed by the original text, and clear that cache when the options/search version changes (for example via _optionsVersion). Update IsItemTextMatch and GetHighlightIndex to reuse the cached folded value when SearchIgnoreDiacritics is enabled, while preserving existing matching and highlighting behavior.
2624-2639: 🚀 Performance & Scalability | 🔵 Trivial | 💤 Low value
GetSelectAllCandidateItemsallocates a new list on every render.
GetSelectAllStateruns during each callout render and materializes the full candidate list. For long item collections this repeats the filter on every keystroke. Consider counting without materializing, or caching the candidates with the existing search/options/selection versions.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.razor.cs` around lines 2624 - 2639, Update GetSelectAllState and GetSelectAllCandidateItems to avoid materializing a new candidate list on every render; count matching normal, visible, enabled items directly while preserving the existing empty, all-selected, and any-selected results. If caching is preferred, invalidate it whenever the searched items or relevant dropdown options/selection state changes.src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/BitDropdownDemo.razor.cs (2)
252-263: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winAdd the missing
DefaultValueto the two new delegate entries.Every other nullable parameter in this table sets
DefaultValue = "null", includingSearchFunctionandDynamicValueGenerator.ExistsSelectedItemFunctionandFindItemFunctionomit it, so the rendered reference table shows an empty default cell for these two rows only.♻️ Proposed fix
Name = "ExistsSelectedItemFunction", Type = "Func<ICollection<TItem>, string, bool>?", + DefaultValue = "null", Description = "Decides whether the text committed in the ComboBox mode already stands for one of the selected items, in place of the default comparison of that text with the item texts, ignoring case. It receives the selected items and the committed text, and returning true stops the commit, so the same item cannot be selected (or created) twice under a name your data considers equivalent.", }, new() { Name = "FindItemFunction", Type = "Func<ICollection<TItem>, string, TItem?>?", + DefaultValue = "null", Description = "Finds the item the text committed in the ComboBox mode stands for, in place of the default comparison of that text with the item texts, ignoring case. It receives the items and the committed text; the item it returns gets selected, and only when it returns none does AutoSelectFirstMatch and then Dynamic get their turn.",🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/BitDropdownDemo.razor.cs` around lines 252 - 263, Add DefaultValue = "null" to the ExistsSelectedItemFunction and FindItemFunction delegate entries, matching the existing nullable parameter metadata such as SearchFunction and DynamicValueGenerator.
30-50: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueRestore the alphabetical order of the parameter table.
The table is otherwise alphabetical, which is how a reader locates a parameter.
HideSelectedItemsandHighlightSearchnow sit betweenAutoSelectFirstMatchandCalloutFooterTemplate, andClearButtonAriaLabelsits afterColor. MoveHideSelectedItemsandHighlightSearchnext toHeaderTemplate, and moveClearButtonAriaLabelbeforeColor.Also applies to: 144-150
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/BitDropdownDemo.razor.cs` around lines 30 - 50, Restore alphabetical ordering in the parameter table: move the HideSelectedItems and HighlightSearch entries to immediately follow HeaderTemplate, and move ClearButtonAriaLabel to immediately precede Color. Keep each entry’s existing definition unchanged.src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownCustomDemo.razor.samples.cs (1)
1049-1060: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueAlign the indentation inside the
GetDataCustomssample.The first list element is indented by four spaces and the remaining eight elements by eight spaces. This string is displayed to the reader as the copyable sample, so the misalignment is visible.
♻️ Proposed fix
private List<Product> GetDataCustoms() => new() { new() { Type = BitDropdownItemType.Header, Text = ""Items"", Payload = new DropdownItemData { IconName = ""BulletedList2"" } }, - new() { Text = ""Item a"", Value = ""A"", Payload = new DropdownItemData { IconName = ""Memo"" } }, - new() { Text = ""Item b"", Value = ""B"", Payload = new DropdownItemData { IconName = ""Print"" } }, - new() { Text = ""Item c"", Value = ""C"", Payload = new DropdownItemData { IconName = ""ShoppingCart"" } }, - new() { Type = BitDropdownItemType.Divider }, - new() { Type = BitDropdownItemType.Header, Text = ""More Items"", Payload = new DropdownItemData { IconName = ""BulletedTreeList"" } }, - new() { Text = ""Item d"", Value = ""D"", Payload = new DropdownItemData { IconName = ""Train"" } }, - new() { Text = ""Item e"", Value = ""E"", Payload = new DropdownItemData { IconName = ""Repair"" } }, - new() { Text = ""Item f"", Value = ""F"", Payload = new DropdownItemData { IconName = ""Running"" } } + new() { Text = ""Item a"", Value = ""A"", Payload = new DropdownItemData { IconName = ""Memo"" } }, + new() { Text = ""Item b"", Value = ""B"", Payload = new DropdownItemData { IconName = ""Print"" } }, + new() { Text = ""Item c"", Value = ""C"", Payload = new DropdownItemData { IconName = ""ShoppingCart"" } }, + new() { Type = BitDropdownItemType.Divider }, + new() { Type = BitDropdownItemType.Header, Text = ""More Items"", Payload = new DropdownItemData { IconName = ""BulletedTreeList"" } }, + new() { Text = ""Item d"", Value = ""D"", Payload = new DropdownItemData { IconName = ""Train"" } }, + new() { Text = ""Item e"", Value = ""E"", Payload = new DropdownItemData { IconName = ""Repair"" } }, + new() { Text = ""Item f"", Value = ""F"", Payload = new DropdownItemData { IconName = ""Running"" } } };🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownCustomDemo.razor.samples.cs` around lines 1049 - 1060, Align the indentation of every initializer inside the GetDataCustoms list so all elements use the same indentation as the first element, preserving the existing item content and ordering.src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownCustomDemo.razor (1)
10-11: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueAdd
Nameto the generated parameter table.
BitDropdowninheritsNamefromBitInputBase, and it binds that value to the hidden native<select>withname="@name". AddNametoBitDropdownDemo.razor.csso the reference matches the prose.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownCustomDemo.razor` around lines 10 - 11, Add the inherited Name parameter to the generated parameter table in BitDropdownDemo.razor.cs, alongside the existing BitDropdown parameters, so it documents the Name value used by the hidden native select and matches the prose in _BitDropdownCustomDemo.razor.src/BlazorUI/Tests/Bit.BlazorUI.Tests/Components/Inputs/Dropdown/BitDropdownLoadingTests.cs (1)
10-19: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winSet the JSInterop mode to loose in this test.
Every other
BitDropdowntest that renders items and then re-renders setsContext.JSInterop.Mode = JSRuntimeMode.Loose;first. This test does not.BitDropdowncalls into JS from its parameter and render hooks, so the second render at line 15 can reach a JS call. In the default strict mode bUnit throwsJSRuntimeUnhandledInvocationExceptionfor any unplanned call, which makes this test fragile against unrelated changes in the component.💚 Proposed fix
public void BitDropdownShouldKeepTheSelectionWhenLoadingEnds() { + Context.JSInterop.Mode = JSRuntimeMode.Loose; + var component = RenderComponent<BitDropdownLoadingTest>(parameters => parameters.Add(p => p.IsLoading, true));🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/BlazorUI/Tests/Bit.BlazorUI.Tests/Components/Inputs/Dropdown/BitDropdownLoadingTests.cs` around lines 10 - 19, Set Context.JSInterop.Mode to JSRuntimeMode.Loose at the start of BitDropdownShouldKeepTheSelectionWhenLoadingEnds, before rendering the component, so parameter and render-hook JS calls remain unplanned during the subsequent re-render.src/BlazorUI/Tests/Bit.BlazorUI.Tests/Components/Inputs/Dropdown/BitDropdownTests.cs (1)
2192-2233: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winGood coverage of the diacritic folding, with one gap.
This test proves the highlighted range still lines up with the accented text for
JoséandMüller. Both are precomposed single code points, so folding them keeps one character per character. It does not cover a text that is already decomposed (for exampleJoséwritten aseplus U+0301), where folding can change the character count and shift the highlight range. That is the exact case thehighlightedguard in_BitDropdownItem.razordoes not defend against.Consider adding a decomposed item to
GetAccentedDropdownItemsto close the gap.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/BlazorUI/Tests/Bit.BlazorUI.Tests/Components/Inputs/Dropdown/BitDropdownTests.cs` around lines 2192 - 2233, Extend GetAccentedDropdownItems with an item containing a decomposed accented character, such as a base letter followed by a combining diacritic, and update BitDropdownSearchIgnoreDiacriticsShouldMatchTheFoldedText to search for and assert that item. Verify highlighted output remains correct when folding changes the character count, covering the highlighted guard in _BitDropdownItem.razor.src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownOptionDemo.razor (1)
1509-1511: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueThe Virtualization example renders for MCP clients while every other example opts out.
Every other
DemoExamplein this file carriesPreventRenderForMcpClient. This one does not. The body is only a text note, so the behavior is harmless, but the difference looks unintentional. Confirm the omission is deliberate.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownOptionDemo.razor` around lines 1509 - 1511, Update the Virtualization DemoExample identified by example24 to explicitly use the same PreventRenderForMcpClient setting as the other examples in this file, unless the omission is intentionally required; preserve its title, RazorCode, Id, and explanatory content.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownItemDemo.razor`:
- Around line 83-88: Update the StickyHeaders multi-select example and the
matching examples around the referenced locations to use
DefaultValues="@(Array.Empty<string>())" instead of
DefaultValue="`@string.Empty`". Preserve the existing MultiSelect configuration
and other dropdown parameters.
---
Nitpick comments:
In `@src/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.razor.cs`:
- Around line 2355-2400: Cache diacritic-folded item text in the dropdown, keyed
by the original text, and clear that cache when the options/search version
changes (for example via _optionsVersion). Update IsItemTextMatch and
GetHighlightIndex to reuse the cached folded value when SearchIgnoreDiacritics
is enabled, while preserving existing matching and highlighting behavior.
- Around line 2624-2639: Update GetSelectAllState and GetSelectAllCandidateItems
to avoid materializing a new candidate list on every render; count matching
normal, visible, enabled items directly while preserving the existing empty,
all-selected, and any-selected results. If caching is preferred, invalidate it
whenever the searched items or relevant dropdown options/selection state
changes.
In
`@src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownCustomDemo.razor`:
- Around line 10-11: Add the inherited Name parameter to the generated parameter
table in BitDropdownDemo.razor.cs, alongside the existing BitDropdown
parameters, so it documents the Name value used by the hidden native select and
matches the prose in _BitDropdownCustomDemo.razor.
In
`@src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownCustomDemo.razor.samples.cs`:
- Around line 1049-1060: Align the indentation of every initializer inside the
GetDataCustoms list so all elements use the same indentation as the first
element, preserving the existing item content and ordering.
In
`@src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownOptionDemo.razor`:
- Around line 1509-1511: Update the Virtualization DemoExample identified by
example24 to explicitly use the same PreventRenderForMcpClient setting as the
other examples in this file, unless the omission is intentionally required;
preserve its title, RazorCode, Id, and explanatory content.
In
`@src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/BitDropdownDemo.razor.cs`:
- Around line 252-263: Add DefaultValue = "null" to the
ExistsSelectedItemFunction and FindItemFunction delegate entries, matching the
existing nullable parameter metadata such as SearchFunction and
DynamicValueGenerator.
- Around line 30-50: Restore alphabetical ordering in the parameter table: move
the HideSelectedItems and HighlightSearch entries to immediately follow
HeaderTemplate, and move ClearButtonAriaLabel to immediately precede Color. Keep
each entry’s existing definition unchanged.
In
`@src/BlazorUI/Tests/Bit.BlazorUI.Tests/Components/Inputs/Dropdown/BitDropdownLoadingTests.cs`:
- Around line 10-19: Set Context.JSInterop.Mode to JSRuntimeMode.Loose at the
start of BitDropdownShouldKeepTheSelectionWhenLoadingEnds, before rendering the
component, so parameter and render-hook JS calls remain unplanned during the
subsequent re-render.
In
`@src/BlazorUI/Tests/Bit.BlazorUI.Tests/Components/Inputs/Dropdown/BitDropdownTests.cs`:
- Around line 2192-2233: Extend GetAccentedDropdownItems with an item containing
a decomposed accented character, such as a base letter followed by a combining
diacritic, and update BitDropdownSearchIgnoreDiacriticsShouldMatchTheFoldedText
to search for and assert that item. Verify highlighted output remains correct
when folding changes the character count, covering the highlighted guard in
_BitDropdownItem.razor.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 778d8b34-83b0-40d7-a81f-e48401077422
📒 Files selected for processing (24)
src/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.razorsrc/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.razor.cssrc/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.scsssrc/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdownClassStyles.cssrc/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdownOption.cssrc/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdownSearchMode.cssrc/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/_BitDropdownItem.razorsrc/BlazorUI/Bit.BlazorUI/Extensions/JsInterop/DropdownsJsRuntimeExtensions.cssrc/BlazorUI/Bit.BlazorUI/Scripts/Dropdowns.tssrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/BitDropdownDemo.razorsrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/BitDropdownDemo.razor.cssrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/BitDropdownDemo.razor.scsssrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownCustomDemo.razorsrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownCustomDemo.razor.cssrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownCustomDemo.razor.samples.cssrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownItemDemo.razorsrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownItemDemo.razor.cssrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownItemDemo.razor.samples.cssrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownOptionDemo.razorsrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownOptionDemo.razor.cssrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownOptionDemo.razor.samples.cssrc/BlazorUI/Tests/Bit.BlazorUI.Tests/Components/Inputs/Dropdown/BitDropdownLoadingTest.razorsrc/BlazorUI/Tests/Bit.BlazorUI.Tests/Components/Inputs/Dropdown/BitDropdownLoadingTests.cssrc/BlazorUI/Tests/Bit.BlazorUI.Tests/Components/Inputs/Dropdown/BitDropdownTests.cs
…into 12741-blazorui-dropdown-improvements
Member
Author
|
@coderabbitai full-review |
|
✅ Action performedFull review finished. |
There was a problem hiding this comment.
Actionable comments posted: 4
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.scss (1)
672-676: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winDrive the clear button and the responsive add button from
--bit-drp-h.
.bit-drp-clrand.bit-drp-caikeep a fixedspacing(3.75)height..bit-drp-smsets--bit-drp-htospacing(3.25), so a small dropdown withShowClearButtonis forced taller than its configured size. A large dropdown (spacing(5)) leaves the button smaller than the control. The same root cause was reported earlier for.bit-drp-pre/.bit-drp-suf, which now use the variable.🎨 Proposed fix
.bit-drp-clr, .bit-drp-cai { display: flex; - width: spacing(3.75); - height: spacing(3.75); + width: var(--bit-drp-h); + height: var(--bit-drp-h); justify-content: center;🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.scss` around lines 672 - 676, Update the shared .bit-drp-clr and .bit-drp-cai styles to derive their height from the dropdown’s --bit-drp-h custom property instead of fixed spacing(3.75), matching the existing .bit-drp-pre and .bit-drp-suf behavior while preserving their width and flex layout.
♻️ Duplicate comments (1)
src/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.razor.cs (1)
2093-2097: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winTab still runs its browser default before the callout closes.
Tabis not inCALLOUT_KEYSinDropdowns.ts, so its default is not prevented. The browser moves the focus to the element that follows the callout in DOM order, and this handler then returns the focus to the trigger. The user-visible result is that Tab and Shift+Tab appear to do nothing.Add
Tabto the prevented keys inDropdowns.tsand move the focus deliberately here, or leave the default in place and do not refocus the trigger onTab.This repeats an earlier review comment.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.razor.cs` around lines 2093 - 2097, Add Tab to the prevented-key set CALLOUT_KEYS in Dropdowns.ts so its browser default does not run, and retain the deliberate focus restoration in CloseCalloutAndRestoreFocus for the "Tab" case of the dropdown keyboard handler. Ensure Tab and Shift+Tab use the intended focus movement rather than being restored to the trigger after native navigation.
🧹 Nitpick comments (5)
src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/BitDropdownDemo.razor (1)
6-6: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueShorten the
PageOutletdescription.
PageOutlet.Descriptionfeeds the page meta description. This value is a single sentence of roughly 800 characters. Search engines truncate meta descriptions near 160 characters, so most of the feature list is not shown. Keep a short summary here and leave the full detail in theDemoPagedescription on line 11.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/BitDropdownDemo.razor` at line 6, Shorten the PageOutlet Description value to a concise summary suitable for search-engine meta descriptions, targeting roughly 160 characters or fewer. Preserve the full feature list in the DemoPage description and change only the PageOutlet metadata text.src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/BitDropdownDemo.razor.cs (1)
391-402: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueKeep the parameter table alphabetical.
The list is alphabetical elsewhere.
MaxSelectedItemsprecedesMaxDisplayedItemsat lines 391-402, andOverflowTextFormatprecedesOptionsat lines 534-547. Swap the two pairs so readers can find the new parameters.Also applies to: 534-540
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/BitDropdownDemo.razor.cs` around lines 391 - 402, Reorder the parameter entries in the parameter table alphabetically: move MaxDisplayedItems before MaxSelectedItems, and move Options before OverflowTextFormat. Keep each entry’s existing metadata and description unchanged.src/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.scss (1)
848-866: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueSimplify the spinner animation and consider reduced motion.
Line 858 sets the timing function to
linearthrough theanimationshorthand, and line 859 immediately overrides it. Declare the timing function once. The spinner also animates continuously; add aprefers-reduced-motion: reducefallback if the design system supports one.♻️ Proposed fix
- animation: bit-drp-spinner-animation 1.3s linear infinite; - animation-timing-function: cubic-bezier(0.53, 0.21, 0.29, 0.67); + animation: bit-drp-spinner-animation 1.3s cubic-bezier(0.53, 0.21, 0.29, 0.67) infinite; + + `@media` (prefers-reduced-motion: reduce) { + animation-duration: 3s; + } }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.scss` around lines 848 - 866, Update the .bit-drp-spn animation declaration to define the intended timing function only once instead of overriding the shorthand’s linear value with animation-timing-function. Add the project’s supported prefers-reduced-motion: reduce fallback for this spinner so continuous animation is disabled or otherwise reduced while preserving normal behavior by default.src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownOptionDemo.razor.samples.cs (1)
900-912: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winDeclare
DropdownItemDatain theexample13CsharpCodesample.The Razor part of example 13 casts
item.Data as DropdownItemData, anddataItemsbuildsnew DropdownItemData { ... }. The C# sample does not declare that class, so the snippet does not compile when copied. The matching sample in_BitDropdownItemDemo.razor.samples.csdeclares it.📝 Proposed fix
private readonly string example13CsharpCode = @" +public class DropdownItemData +{ + public string? IconName { get; set; } +} + private readonly List<BitDropdownItem<string>> dataItems =🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownOptionDemo.razor.samples.cs` around lines 900 - 912, Update the example13CsharpCode sample to declare the DropdownItemData class used by its item.Data initializers and the Razor cast, matching the corresponding declaration in the BitDropdownItem demo sample.src/BlazorUI/Bit.BlazorUI/Scripts/Dropdowns.ts (1)
196-205: 🚀 Performance & Scalability | 🔵 Trivial | ⚡ Quick winThe re-render detection compares element identity only.
Virtualizecan reuse the same DOM nodes and change only their content. In that caserendered[0] !== firststays false for all 20 frames, so everyPageUp/PageDownwaits the fullVIRTUALIZE_RENDER_FRAMESbudget before the focus moves. On a 60 Hz display that is about 330 ms of latency per key press.Compare a value that changes with the window, such as the first item's
idortextContent, in addition to the identity check.♻️ Proposed change
const first = items[0]; const last = items[items.length - 1]; + const firstKey = first.id || first.textContent; + const lastKey = last.id || last.textContent; scroller.scrollTop = top; for (let i = 0; i < Dropdowns.VIRTUALIZE_RENDER_FRAMES; i++) { await new Promise<void>(resolve => requestAnimationFrame(() => resolve())); const rendered = Dropdowns._getItems(callout); - if (rendered.length > 0 && (rendered[0] !== first || rendered[rendered.length - 1] !== last)) { + const renderedFirst = rendered[0]; + const renderedLast = rendered[rendered.length - 1]; + if (rendered.length > 0 && + (renderedFirst !== first || renderedLast !== last || + (renderedFirst.id || renderedFirst.textContent) !== firstKey || + (renderedLast.id || renderedLast.textContent) !== lastKey)) { return { items: rendered, mode: nextMode }; } }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/BlazorUI/Bit.BlazorUI/Scripts/Dropdowns.ts` around lines 196 - 205, Update the re-render detection loop in the Dropdowns virtualization flow to compare a window-dependent value, such as the first and last rendered items’ id or textContent, alongside DOM element identity. Ensure reused nodes with changed content cause immediate return, while preserving the existing frame polling and fallback behavior.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.razor`:
- Around line 437-446: Update the shared loadingContent and emptyContent
fragments used within the listbox scroll container to make their root elements
presentational, preserving the existing loading and empty-state content and
status announcement behavior. Do not alter option rendering or the listbox
container itself.
In `@src/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.scss`:
- Around line 163-167: Insert a blank line between the position: relative
declaration and the explanatory comment in the Dropdown styles, leaving the
align-items and min-height declarations unchanged.
In
`@src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownCustomDemo.razor`:
- Around line 1420-1422: Rewrite the broken OpenOnFocus description sentence to
state that the component distinguishes user-initiated focus from focus caused by
its own focus management. Apply the same wording in _BitDropdownCustomDemo.razor
lines 1420-1422, _BitDropdownItemDemo.razor lines 1363-1365, and
_BitDropdownOptionDemo.razor lines 1743-1747.
In
`@src/BlazorUI/Tests/Bit.BlazorUI.Tests/Components/Inputs/Dropdown/BitDropdownLoadingTests.cs`:
- Around line 12-15: Configure bUnit JS interop as loose in
BitDropdownLoadingTests by setting Context.JSInterop.Mode to JSRuntimeMode.Loose
before the initial RenderComponent<BitDropdownLoadingTest> call. Keep the
existing IsLoading parameter render transitions unchanged.
---
Outside diff comments:
In `@src/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.scss`:
- Around line 672-676: Update the shared .bit-drp-clr and .bit-drp-cai styles to
derive their height from the dropdown’s --bit-drp-h custom property instead of
fixed spacing(3.75), matching the existing .bit-drp-pre and .bit-drp-suf
behavior while preserving their width and flex layout.
---
Duplicate comments:
In `@src/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.razor.cs`:
- Around line 2093-2097: Add Tab to the prevented-key set CALLOUT_KEYS in
Dropdowns.ts so its browser default does not run, and retain the deliberate
focus restoration in CloseCalloutAndRestoreFocus for the "Tab" case of the
dropdown keyboard handler. Ensure Tab and Shift+Tab use the intended focus
movement rather than being restored to the trigger after native navigation.
---
Nitpick comments:
In `@src/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.scss`:
- Around line 848-866: Update the .bit-drp-spn animation declaration to define
the intended timing function only once instead of overriding the shorthand’s
linear value with animation-timing-function. Add the project’s supported
prefers-reduced-motion: reduce fallback for this spinner so continuous animation
is disabled or otherwise reduced while preserving normal behavior by default.
In `@src/BlazorUI/Bit.BlazorUI/Scripts/Dropdowns.ts`:
- Around line 196-205: Update the re-render detection loop in the Dropdowns
virtualization flow to compare a window-dependent value, such as the first and
last rendered items’ id or textContent, alongside DOM element identity. Ensure
reused nodes with changed content cause immediate return, while preserving the
existing frame polling and fallback behavior.
In
`@src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownOptionDemo.razor.samples.cs`:
- Around line 900-912: Update the example13CsharpCode sample to declare the
DropdownItemData class used by its item.Data initializers and the Razor cast,
matching the corresponding declaration in the BitDropdownItem demo sample.
In
`@src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/BitDropdownDemo.razor`:
- Line 6: Shorten the PageOutlet Description value to a concise summary suitable
for search-engine meta descriptions, targeting roughly 160 characters or fewer.
Preserve the full feature list in the DemoPage description and change only the
PageOutlet metadata text.
In
`@src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/BitDropdownDemo.razor.cs`:
- Around line 391-402: Reorder the parameter entries in the parameter table
alphabetically: move MaxDisplayedItems before MaxSelectedItems, and move Options
before OverflowTextFormat. Keep each entry’s existing metadata and description
unchanged.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: abab0873-0cd2-4541-be01-d3f9e63dcfaf
📒 Files selected for processing (24)
src/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.razorsrc/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.razor.cssrc/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdown.scsssrc/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdownClassStyles.cssrc/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdownOption.cssrc/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/BitDropdownSearchMode.cssrc/BlazorUI/Bit.BlazorUI/Components/Inputs/Dropdown/_BitDropdownItem.razorsrc/BlazorUI/Bit.BlazorUI/Extensions/JsInterop/DropdownsJsRuntimeExtensions.cssrc/BlazorUI/Bit.BlazorUI/Scripts/Dropdowns.tssrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/BitDropdownDemo.razorsrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/BitDropdownDemo.razor.cssrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/BitDropdownDemo.razor.scsssrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownCustomDemo.razorsrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownCustomDemo.razor.cssrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownCustomDemo.razor.samples.cssrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownItemDemo.razorsrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownItemDemo.razor.cssrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownItemDemo.razor.samples.cssrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownOptionDemo.razorsrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownOptionDemo.razor.cssrc/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Pages/Components/Inputs/Dropdown/_BitDropdownOptionDemo.razor.samples.cssrc/BlazorUI/Tests/Bit.BlazorUI.Tests/Components/Inputs/Dropdown/BitDropdownLoadingTest.razorsrc/BlazorUI/Tests/Bit.BlazorUI.Tests/Components/Inputs/Dropdown/BitDropdownLoadingTests.cssrc/BlazorUI/Tests/Bit.BlazorUI.Tests/Components/Inputs/Dropdown/BitDropdownTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #12741
Summary by CodeRabbit