Skip to content

Rename ServerConnectionException to TransientException (#12477)#12485

Merged
yasmoradi merged 1 commit into
bitfoundation:developfrom
yasmoradi:12477
Jun 18, 2026
Merged

Rename ServerConnectionException to TransientException (#12477)#12485
yasmoradi merged 1 commit into
bitfoundation:developfrom
yasmoradi:12477

Conversation

@yasmoradi

@yasmoradi yasmoradi commented Jun 18, 2026

Copy link
Copy Markdown
Member

closes #12477

Summary by CodeRabbit

  • Improvements
    • Enhanced exception handling to better manage transient connection failures, improving offline reliability and the application's response to temporary server connectivity issues.
    • Updated chatbot system prompt formatting specifications.

@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 09d4fa1f-9a57-400b-a186-db172075dab5

📥 Commits

Reviewing files that changed from the base of the PR and between 0e4e067 and db3162e.

📒 Files selected for processing (7)
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Components/Parameters.cs
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Infrastructure/Services/AuthManager.cs
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Infrastructure/Services/ClientExceptionHandlerBase.cs
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Infrastructure/Services/HttpMessageHandlers/ExceptionDelegatingHandler.cs
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Core/Infrastructure/Services/SyncService.cs
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Server/Boilerplate.Server.Api/Features/Chatbot/SystemPromptConfiguration.cs
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Shared/Infrastructure/Exceptions/TransientException.cs

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting


Walkthrough

ServerConnectionException is renamed to TransientException in the shared exceptions file, and all consuming sites (ExceptionDelegatingHandler, AuthManager, SyncService, ClientExceptionHandlerBase, and Parameters XML docs) are updated to reference the new name. Separately, the chatbot system prompt literal in SystemPromptConfiguration is reformatted from a triple-quoted string to a verbatim @-string with single-quoted JSON example keys.

Changes

ServerConnectionException → TransientException Rename

Layer / File(s) Summary
TransientException class declaration
src/.../Shared/Infrastructure/Exceptions/TransientException.cs
Exception class renamed from ServerConnectionException to TransientException; all three constructor overloads updated to the new declaring type.
Consumer updates across HTTP handler, auth, sync, display, and docs
src/.../HttpMessageHandlers/ExceptionDelegatingHandler.cs, src/.../Services/AuthManager.cs, src/.../Services/SyncService.cs, src/.../Services/ClientExceptionHandlerBase.cs, src/.../Components/Parameters.cs
ExceptionDelegatingHandler throws TransientException; AuthManager SignOut and RefreshTokenImplementation catch filters reference TransientException; SyncService ignores TransientException; ClientExceptionHandlerBase.GetDisplayKind maps TransientException to NonInterrupting; Parameters XML doc updated.

Chatbot System Prompt Reformatting

Layer / File(s) Summary
System prompt literal reformatting
src/.../Features/Chatbot/SystemPromptConfiguration.cs
GetAnalyzeProductImageSystemPromptMarkdown switches from a triple-quoted indented literal to a verbatim @-string; RESPONSE FORMAT example JSON keys change from double quotes to single quotes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐇 A name change hops through the code today,
ServerConnection quietly slips away.
Now Transient bounces with lighter cheer,
Catching exceptions both far and near.
The chatbot's prompt got a new coat too —
Single quotes gleaming, fresh as morning dew! ✨

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@yasmoradi yasmoradi merged commit c788d7d into bitfoundation:develop Jun 18, 2026
1 of 3 checks passed
@yasmoradi yasmoradi deleted the 12477 branch June 18, 2026 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bit Boilerplate's ServerConnectionException name is not clear

1 participant