Extract task reading and writing from Task data class #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunkup
force-pushed
the
task-reader-writer
branch
from
bc758bc to
49dcccc
Compare
5 tasks
sunkup
force-pushed
the
task-reader-writer
branch
from
49dcccc to
89e4813
Compare
rfc2822
approved these changes
Feb 2, 2026
Member
rfc2822
left a comment
rfc2822
left a comment
There was a problem hiding this comment.
As this doesn't change logic, it should be quite safe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #41 (for calendar)
Required for bitfireAT/davx5-ose#1959
Task is a data class and as such it shouldn't have hidden logic. This PR extracts reading/writing Tasks into respective classes. No logic has been changed.
In a later stage of refactoring, we will be able to completely remove the Task class and map directly between iCalendar ↔ Task provider data rows.