Skip to content

refactor: Delegate rusqlite::Connection persister to transaction persister#421

Open
shinigami-777 wants to merge 1 commit intobitcoindevkit:masterfrom
shinigami-777:rusqlite-connection-persister-delegation
Open

refactor: Delegate rusqlite::Connection persister to transaction persister#421
shinigami-777 wants to merge 1 commit intobitcoindevkit:masterfrom
shinigami-777:rusqlite-connection-persister-delegation

Conversation

@shinigami-777
Copy link
Copy Markdown

Description

Issue: #279
The WalletPersister implementations for rusqlite::Connection and rusqlite::Transaction are currently independent. The connection persister just creates a new transaction, does what the transaction persister does, and then commits. This refactor removes that duplication by having the Connection impl delegate directly to the Transaction impl.

Notes to the reviewers

Changelog notice

Checklists

All Submissions:

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.17%. Comparing base (4e202c8) to head (5415d0c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #421      +/-   ##
==========================================
+ Coverage   80.04%   80.17%   +0.13%     
==========================================
  Files          24       24              
  Lines        5336     5336              
  Branches      242      242              
==========================================
+ Hits         4271     4278       +7     
+ Misses        987      980       -7     
  Partials       78       78              
Flag Coverage Δ
rust 80.17% <100.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ValuedMammal ValuedMammal moved this to Needs Review in BDK Wallet Mar 30, 2026
@ValuedMammal ValuedMammal added this to the Wallet 3.1.0 milestone Mar 30, 2026
@ValuedMammal
Copy link
Copy Markdown
Collaborator

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Needs Review

Development

Successfully merging this pull request may close these issues.

Delegate rusqlite::Connection persister to transaction persister

2 participants