Skip to content

feat(wallet): add LoadParams::two_path_descriptor method#418

Open
yukibtc wants to merge 1 commit intobitcoindevkit:masterfrom
yukibtc:wallet-load-two-path-desc
Open

feat(wallet): add LoadParams::two_path_descriptor method#418
yukibtc wants to merge 1 commit intobitcoindevkit:masterfrom
yukibtc:wallet-load-two-path-desc

Conversation

@yukibtc
Copy link
Copy Markdown
Contributor

@yukibtc yukibtc commented Mar 24, 2026

Description

Added LoadParams::two_path_descriptor to validate that both the external and internal wallet descriptors match an expected two-path descriptor during load.

Changelog notice

  • Add LoadParams::two_path_descriptor method

Checklists

All Submissions:

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.08%. Comparing base (cb2c7ed) to head (c4dbe42).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #418      +/-   ##
==========================================
+ Coverage   80.04%   80.08%   +0.04%     
==========================================
  Files          24       24              
  Lines        5336     5347      +11     
  Branches      242      242              
==========================================
+ Hits         4271     4282      +11     
  Misses        987      987              
  Partials       78       78              
Flag Coverage Δ
rust 80.08% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yukibtc yukibtc force-pushed the wallet-load-two-path-desc branch from 0cc326e to dbb87b2 Compare March 24, 2026 18:44
Copy link
Copy Markdown
Contributor

@Dmenec Dmenec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approach ACK dbb87b2

Nit: Not sure if there's prior context in the repo, but would it make sense to use "multipath descriptor" following BIP-389 terminology instead of "two-path descriptor"?

Signed-off-by: Yuki Kishimoto <yukikishimoto@protonmail.com>
@yukibtc yukibtc force-pushed the wallet-load-two-path-desc branch from dbb87b2 to c4dbe42 Compare March 28, 2026 08:02
@yukibtc
Copy link
Copy Markdown
Contributor Author

yukibtc commented Mar 28, 2026

Nit: Not sure if there's prior context in the repo, but would it make sense to use "multipath descriptor" following BIP-389 terminology instead of "two-path descriptor"?

Thanks for the review.

I've used the "two_path" instead of "multipath" as I see other constructors are named in that way, like Wallet::create_from_two_path_descriptor or CreateParams::new_two_path.

@ValuedMammal @oleonardolima

@ValuedMammal ValuedMammal added the new feature New feature or request label Mar 28, 2026
@ValuedMammal ValuedMammal added this to the Wallet 3.1.0 milestone Mar 28, 2026
@ValuedMammal ValuedMammal moved this to Needs Review in BDK Wallet Mar 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new feature New feature or request

Projects

Status: Needs Review

Development

Successfully merging this pull request may close these issues.

3 participants