wip,draft: Add async support to persist_test_utils#343
Draft
ValuedMammal wants to merge 3 commits intobitcoindevkit:masterfrom
Draft
wip,draft: Add async support to persist_test_utils#343ValuedMammal wants to merge 3 commits intobitcoindevkit:masterfrom
persist_test_utils#343ValuedMammal wants to merge 3 commits intobitcoindevkit:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #343 +/- ##
==========================================
- Coverage 86.46% 85.43% -1.04%
==========================================
Files 25 25
Lines 8527 8649 +122
==========================================
+ Hits 7373 7389 +16
- Misses 1154 1260 +106
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d6f2cdc to
15149b5
Compare
- deps: Make tempfile, anyhow dev-dependencies
15149b5 to
bf0057f
Compare
ValuedMammal
commented
Feb 19, 2026
Comment on lines
+146
to
+151
| pub fn persist_multiple_wallet_changesets<F, P>(create_stores: F) -> Result<(), PersistError> | ||
| where | ||
| F: Fn() -> Result<(P, P), P::Error>, | ||
| P: WalletPersister, | ||
| P::Error: StdErr + 'static, | ||
| { |
Collaborator
Author
There was a problem hiding this comment.
@110CodingP I changed this by removing the &Path arg from the create_stores Fn, which means this function is no longer in control of the path in which the stores are created. After thinking about it I'm not sure this is a feature that needs to be tested. Any thought about whether to keep or improve it somehow?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Expands
persist_test_utilsmodule by adding a functionpersist_wallet_changeset_asyncto be used for testing anAsyncWalletPersisterimplementation. For now this is still WIP.Notes to the reviewers
Changelog notice
Checklists
All Submissions:
just pbefore pushingNew Features:
Bugfixes: