feat(chain): add ChainPosition::blocks_since_conf - #2263
Open
Dmenec wants to merge 1 commit into
Open
Conversation
5 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2263 +/- ##
==========================================
+ Coverage 78.36% 78.41% +0.04%
==========================================
Files 30 30
Lines 5945 5952 +7
Branches 281 282 +1
==========================================
+ Hits 4659 4667 +8
+ Misses 1210 1209 -1
Partials 76 76
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggested by @nymius in #2246 (comment).
Description
Adds
ChainPosition::blocks_since_conf(tip), which returns the number of blocks mined on top of a confirmed position's block, given the chaintip. ReturnsNoneif the position is unconfirmed, or if the confirmation height is abovetip.Changelog notice
ChainPosition::blocks_since_conf, returning the number of blocks mined on top of a confirmed position's block given the chain tip.Checklists
All Submissions:
just pbefore committingNew Features: