Skip to content

ci: switch from coveralls to codecov for coverage reporting #2144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shubham-shinde-442 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ci: switch from coveralls to codecov for coverage reporting #2144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions .github/workflows/code_coverage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,12 @@ on: [push, pull_request]

name: Code Coverage

permissions: {}
permissions:
contents: read
pull-requests: write

jobs:
Codecov:
Coverage:
name: Code Coverage
runs-on: ubuntu-latest
steps:
Expand All @@ -30,10 +32,14 @@ jobs:
run: cargo llvm-cov -q --doctests --branch --all --ignore-filename-regex "(example*|crates/testenv/*)" --all-features --lcov --output-path ./coverage/lcov.info
- name: Generate HTML coverage report
run: genhtml -o coverage-report.html --ignore-errors unmapped ./coverage/lcov.info
Comment on lines 33 to 34
Copy link
Copy Markdown
Collaborator

@oleonardolima oleonardolima Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't we build it with cargo llvm-cov instead, as it's being done in bdk_wallet.

- name: Coveralls upload
uses: coverallsapp/github-action@master
- name: Codecov upload
uses: codecov/codecov-action@671740ac38dd9b0130fbe1cec585b89eea48d3de
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
files: ./coverage/lcov.info
flags: rust
name: codecov-bdk
token: ${{ secrets.CODECOV_TOKEN }}
fail_ci_if_error: false
Copy link
Copy Markdown

@Toyin5 Toyin5 Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the pipeline fail if error?

Copy link
Copy Markdown
Member

@notmandatory notmandatory Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question, I don't think we need to fail, and we don't fail for the bdk_wallet crate either. But worth reconsidering if we begin to see a problem with new PRs not having adequate coverage.
https://github.com/bitcoindevkit/bdk_wallet/blob/fca652370c466c79659afc6ae57c5015d4007b18/.github/workflows/code_coverage.yml#L46

Copy link
Copy Markdown
Author

@shubham-shinde-442 shubham-shinde-442 Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@notmandatory @Toyin5 Thanks for the review, Should I update this to fail, or leave it as it is?

- name: Upload artifact
uses: actions/upload-artifact@v6
with:
Expand Down