[test] Add test_enable_anti_fee_sniping#10
Closed
ValuedMammal wants to merge 4 commits intobitcoindevkit:masterfrom
Closed
[test] Add test_enable_anti_fee_sniping#10ValuedMammal wants to merge 4 commits intobitcoindevkit:masterfrom
test_enable_anti_fee_sniping#10ValuedMammal wants to merge 4 commits intobitcoindevkit:masterfrom
Conversation
feat: bip326 anti-fee sniping made compatible with new current library fix(clippy): fixing clippy CI build error with Box due to large enum variant example to test anti fee snipping, extracted the height from tx checking expected range of values
- Rename MAX_SEQUENCE_VALUE to MAX_RELATIVE_HEIGHT for clarity - Use Script::is_p2tr() for more robust taproot input detection - Replace fallible LockTime::from_height with expect for valid Height - Remove unnecessary clippy allow attributes in lib.rs - Remove Box usage from error and enums - Rename anti_fee_snipping example to anti_fee_sniping
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This draft PR builds on PR #5 and adds a unit test to
selection.rs. I think it would be good to have a test like this included in PR #5 for the purpose of continuous integration.