feat: Add descriptor miniscript constructor method#988
Open
ItoroD wants to merge 1 commit intobitcoindevkit:masterfrom
Open
feat: Add descriptor miniscript constructor method#988ItoroD wants to merge 1 commit intobitcoindevkit:masterfrom
ItoroD wants to merge 1 commit intobitcoindevkit:masterfrom
Conversation
73b8bff to
de91a86
Compare
de91a86 to
461e33b
Compare
Member
|
I started reviewing this this morning and you just sent me down a rabbit hole of looking at old scripts and ways to quickly try new APIs... 🤣 in the end I did that all day and didn't finish the review. I promise you're on my list for tomorrow! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is the third part of #973. Here I am adding in all the methods that accept Miniscript as parameter. The last batch to be added will be new_sh_with_wpkh, new_sh_with_wsh, and new_tr I am testing these ones out and trying to find best why to implement them in a follow up PR.
Notes to the reviewers
These method implementions are not much different from what we have in #973. The main difference is how we parse the string param. In #973 we do
BdkDescriptorPublicKey::from_str(pk)as the param expects a publickey. In this PR we doBDKMiniscript::from_str(&mini_script)as the params we expect is miniscript.Documentation
bdk_walletbitcoinuniffiOther:
new_sh - https://docs.rs/miniscript/12.3.5/miniscript/descriptor/enum.Descriptor.html#method.new_sh
new_wsh - https://docs.rs/miniscript/12.3.5/miniscript/descriptor/enum.Descriptor.html#method.new_wsh
new_sh_wsh - https://docs.rs/miniscript/12.3.5/miniscript/descriptor/enum.Descriptor.html#method.new_sh_wsh
new_bare - https://docs.rs/miniscript/12.3.5/miniscript/descriptor/enum.Descriptor.html#method.new_bare
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features: