Testing the new potential kyoto client#965
Testing the new potential kyoto client#965thunderbiscuit wants to merge 1 commit intobitcoindevkit:masterfrom
Conversation
thunderbiscuit
force-pushed
the
new-kyoto
branch
from
bcb9ca6 to
c0925a0
Compare
|
Do we know why CI is failing? |
| // println("Hello, Compact Block Filters!") | ||
| // val regtestEnv = RegEnv.connectTo(walletName = "faucet", username = "regtest", password = "password") | ||
|
|
||
| val wallet: Wallet = Wallet.createSingle( |
There was a problem hiding this comment.
Should this use a regtest descriptor here? wondering because from what I see BIP86_DESCRIPTOR is created with Network.TESTNET but the wallet is initialized with Network.REGTEST
| wallet.applyUpdate(update) | ||
|
|
||
| val balance = wallet.balance().total.toSat() | ||
| assert(balance > 0uL) |
There was a problem hiding this comment.
Should this use a real test assertion and reenable the funding/mine steps, I think the wallet is never funded and the final assert(...) may be skipped so the test can pass without validating Kyoto sync? Maybe im wrong though
reez
left a comment
reez
left a comment
There was a problem hiding this comment.
Looks good overall and consistent w bdk kyoto, a couple questions comments added
|
I'll update and rebase this once #967 is in, leveraging the regtest on CI. |
ack'd 967 |
3 participants
Trying to connect the dots from bdk_kyoto all the way to the the bindings.
bitcoindevkit/bdk-kyoto#146