test: smoke test Dart full-scan binding call path - #115
Closed
ANAMASGARD wants to merge 1 commit into
Closed
Conversation
Add a narrow Esplora-gated integration test that exercises the generated full-scan request/update path from Dart: startFullScan().build(), EsploraClient.fullScan(), and wallet.applyUpdate(). Success is no-throw completion through the binding path; scan semantics are not asserted. Closes bitcoindevkit#106
6 tasks
Contributor
|
Closing this to stay aligned with maintainer feedback elsewhere in the BDK org (comment on bdk#2242). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a narrow Dart-side smoke test for the generated full-scan binding path (#106).
The test builds a wallet, creates a
FullScanRequestviawallet.startFullScan().build(), callsEsploraClient.fullScan(), and applies the returnedUpdatewithwallet.applyUpdate(...). Assertions are intentionally minimal — success is no-throw completion through the binding path. This does not test Electrum/Esplora scan semantics or wallet discovery behavior.Test plan
dart analyze test/integration/full_scan_smoke_test.dartdart test(unit/offline suite)dart test test/integration/full_scan_smoke_test.dart— skipped without env varsBDK_DART_RUN_INTEGRATION=1 BDK_DART_ESPLORA_URL=... dart test test/integration/full_scan_smoke_test.dart— passesLocal run (screenshot)