test: Add testenv module#26
Merged
ValuedMammal merged 3 commits intobitcoindevkit:masterfrom Feb 11, 2026
Merged
Conversation
Collaborator
|
Thanks, it's a good idea to have some sort of |
12cea4c to
230c07e
Compare
In error types that wrap an underlying error, the underlying error should either be returned by the outer error's source, or rendered by the outer error's Display implementation, but not both. ref: <https://doc.rust-lang.org/std/error/trait.Error.html#error-source>
- test,deps: Add `anyhow` - test: Add `testenv` module
2ae77a1 to
f1db39a
Compare
Collaborator
Author
|
self-ACK f1db39a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a follow up to #5 that introduces a
TestEnvstruct used for integration tests and fixes a number of nitpicks that were previously left out.Summary:
TestEnvstruct with convenient interface for improved ergonomicsgenerate_to_address)client::test_authmodulestd::env::tempdirnode.stop(), as this is handled by theDropimplementation ofNodeget_block_verbose,get_block_header_verboseBlockHash, and Bitcoin Core itself).Checklists
All Submissions:
cargo fmtandcargo clippybefore committing