wallet: mark bip125-replaceable deprecated, remove walletrbf argument#34917
Open
rkrux wants to merge 2 commits intobitcoin:masterfrom
Open
wallet: mark bip125-replaceable deprecated, remove walletrbf argument#34917rkrux wants to merge 2 commits intobitcoin:masterfrom
rkrux wants to merge 2 commits intobitcoin:masterfrom
Conversation
Transactions are replaceable by default since v28 and the corresponding tweaking argument has been removed since v29. The related key from the mempool RPC has been marked deprecated as well since v29, this patch does the same for the wallet.
All transactions are by default replaceable since v28, the wallet need not have a configuration option to opt into RBF signalling because it seems redundant now. The default behaviour of opting into RBF signalling is retained - for now. Users still have the option to opt out of RBF signalling via the individual transaction creation RPC request options.
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. LLM Linter (✨ experimental)Possible typos and grammar issues:
2026-03-25 09:53:59 |
w0xlt
reviewed
Mar 25, 2026
| #if HAVE_SYSTEM | ||
| argsman.AddArg("-walletnotify=<cmd>", "Execute command when a wallet transaction changes. %s in cmd is replaced by TxID, %w is replaced by wallet name, %b is replaced by the hash of the block including the transaction (set to 'unconfirmed' if the transaction is not included) and %h is replaced by the block height (-1 if not included). %w is not currently implemented on windows. On systems where %w is supported, it should NOT be quoted because this would break shell escaping used to invoke the command.", ArgsManager::ALLOW_ANY, OptionsCategory::WALLET); | ||
| #endif | ||
| argsman.AddArg("-walletrbf", strprintf("Send transactions with full-RBF opt-in enabled (RPC only, default: %u)", DEFAULT_WALLET_RBF), ArgsManager::ALLOW_ANY, OptionsCategory::WALLET); |
Contributor
There was a problem hiding this comment.
Removing the -walletrbf registration introduces an upgrade regression: existing configs or service arguments that still set it will now prevent the node from starting.
Shouldn't it remain accepted as a hidden/deprecated no-op rather than being removed outright ?
This was referenced Mar 26, 2026
This was referenced Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch set is in line with the deprecation & removal of outdated
BIP 125 opt-in RBF signalling in wallet transactions.