bip-0044: add Requires header for BIP32 and BIP43#2072
Open
MohammadEglil wants to merge 1 commit intobitcoin:masterfrom
Open
bip-0044: add Requires header for BIP32 and BIP43#2072MohammadEglil wants to merge 1 commit intobitcoin:masterfrom
MohammadEglil wants to merge 1 commit intobitcoin:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a
Requires: 32, 43header to BIP-0044.Motivation
BIP-0044 explicitly states in its abstract and specification that it is based on the HD wallet structure defined in BIP-0032 and applies the purpose scheme defined in BIP-0043.
This dependency is currently described in the text but could be extended to the preamble.
This change would make BIP-0044 more consistent to the BIP process and would make its interoperability with other BIPs clearer.