refactor: rename EventLoop::m_num_clients to m_num_refs#302
Open
Sjors wants to merge 1 commit into
Open
Conversation
Rename the variable and document what it counts, so the loop() exit condition in EventLoop::done() is not misread as "exit when no clients are connected".
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please copy-paste |
ViniciusCestarii
left a comment
ViniciusCestarii
left a comment
Contributor
There was a problem hiding this comment.
ACK d499830, I agree this name is clearer.
| //! Run event loop. Does not return until shutdown. This should only be | ||
| //! called once from the m_thread_id thread. This will block until | ||
| //! the m_num_clients reference count is 0. | ||
| //! the m_num_refs reference count is 0. |
Contributor
There was a problem hiding this comment.
In "refactor: rename EventLoop::m_num_clients to m_num_refs" d499830
nit: "the m_num_refs reference count" is a bit redundant now because "refs" already means references. Could be renamed to "the m_num_refs count is 0" (unrelated but this condition is also incomplete: loop() exits on done(), m_num_refs == 0 and m_async_fns is empty).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename the variable and document what it counts, so the
loop()exit condition inEventLoop::done()is not misread as "exit when no clients are connected".I found myself confused by this while reviewing #269.