Skip to content

test: recursive async IPC calls and cleanups #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryanofsky merged 1 commit into from
Jul 5, 2026
+21 −52
Merged

test: recursive async IPC calls and cleanups #301

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 21 additions & 52 deletions test/mp/test/test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,15 @@
#include <utility>
#include <vector>

//! Assert that a call throws std::runtime_error with the given message.
#define EXPECT_EXCEPTION(call, message) \
try { \
call; \
KJ_EXPECT(false); \

@ryanofsky ryanofsky Jul 5, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In commit "test: recursive async IPC calls" (5519f7f)

Could be better to improve output in this case with something like KJ_FAIL_EXPECT("Expected exception was not thrown: " message)

} catch (const std::runtime_error& e) { \
KJ_EXPECT(std::string_view{e.what()} == message); \
}

namespace mp {
namespace test {

Expand Down Expand Up @@ -234,6 +243,11 @@ KJ_TEST("Call FooInterface methods")

KJ_EXPECT(foo->passFn([]{ return 10; }) == 10);

// Recursive async IPC calls
KJ_EXPECT(foo->passFn([foo]{
return foo->passFn([]{ return 1; });
}) == 1);

std::vector<FooDataRef> data_in;
data_in.push_back(std::make_shared<FooData>(FooData{'H', 'i'}));
data_in.push_back(nullptr);
Expand All @@ -251,14 +265,7 @@ KJ_TEST("Call IPC method after client connection is closed")
KJ_EXPECT(foo->add(1, 2) == 3);
setup.client_disconnect();

bool disconnected{false};
try {
foo->add(1, 2);
} catch (const std::runtime_error& e) {
KJ_EXPECT(std::string_view{e.what()} == "IPC client method called after disconnect.");
disconnected = true;
}
KJ_EXPECT(disconnected);
EXPECT_EXCEPTION(foo->add(1, 2), "IPC client method called after disconnect.");
}

KJ_TEST("Calling IPC method after server connection is closed")
Expand All @@ -268,14 +275,7 @@ KJ_TEST("Calling IPC method after server connection is closed")
KJ_EXPECT(foo->add(1, 2) == 3);
setup.server_disconnect();

bool disconnected{false};
try {
foo->add(1, 2);
} catch (const std::runtime_error& e) {
KJ_EXPECT(std::string_view{e.what()} == "IPC client method call interrupted by disconnect.");
disconnected = true;
}
KJ_EXPECT(disconnected);
EXPECT_EXCEPTION(foo->add(1, 2), "IPC client method call interrupted by disconnect.");
}

KJ_TEST("Calling IPC method and disconnecting during the call")
Expand All @@ -288,14 +288,7 @@ KJ_TEST("Calling IPC method and disconnecting during the call")
// handling the callFn call to make sure this case is handled cleanly.
setup.server->m_impl->m_fn = setup.client_disconnect;

bool disconnected{false};
try {
foo->callFn();
} catch (const std::runtime_error& e) {
KJ_EXPECT(std::string_view{e.what()} == "IPC client method call interrupted by disconnect.");
disconnected = true;
}
KJ_EXPECT(disconnected);
EXPECT_EXCEPTION(foo->callFn(), "IPC client method call interrupted by disconnect.");
}

KJ_TEST("Calling IPC method, disconnecting and blocking during the call")
Expand Down Expand Up @@ -330,14 +323,7 @@ KJ_TEST("Calling IPC method, disconnecting and blocking during the call")
signal.get_future().get();
};

bool disconnected{false};
try {
foo->callFnAsync();
} catch (const std::runtime_error& e) {
KJ_EXPECT(std::string_view{e.what()} == "IPC client method call interrupted by disconnect.");
disconnected = true;
}
KJ_EXPECT(disconnected);
EXPECT_EXCEPTION(foo->callFnAsync(), "IPC client method call interrupted by disconnect.");

// Now that the disconnect has been detected, set signal allowing the
// callFnAsync() IPC call to return. Since signalling may not wake up the
Expand Down Expand Up @@ -374,14 +360,7 @@ KJ_TEST("Worker thread destroyed before it is initialized")
std::this_thread::sleep_for(std::chrono::milliseconds(10));
};

bool disconnected{false};
try {
foo->callFnAsync();
} catch (const std::runtime_error& e) {
KJ_EXPECT(std::string_view{e.what()} == "IPC client method call interrupted by disconnect.");
disconnected = true;
}
KJ_EXPECT(disconnected);
EXPECT_EXCEPTION(foo->callFnAsync(), "IPC client method call interrupted by disconnect.");
}

KJ_TEST("Calling async IPC method, with server disconnect racing the call")
Expand All @@ -406,12 +385,7 @@ KJ_TEST("Calling async IPC method, with server disconnect racing the call")
std::this_thread::sleep_for(std::chrono::milliseconds(10));
};

try {
foo->callFnAsync();
KJ_EXPECT(false);
} catch (const std::runtime_error& e) {
KJ_EXPECT(std::string_view{e.what()} == "IPC client method call interrupted by disconnect.");
}
EXPECT_EXCEPTION(foo->callFnAsync(), "IPC client method call interrupted by disconnect.");
}

KJ_TEST("Calling async IPC method, with server disconnect after cleanup")
Expand All @@ -435,12 +409,7 @@ KJ_TEST("Calling async IPC method, with server disconnect after cleanup")
setup.server_disconnect();
};

try {
foo->callFnAsync();
KJ_EXPECT(false);
} catch (const std::runtime_error& e) {
KJ_EXPECT(std::string_view{e.what()} == "IPC client method call interrupted by disconnect.");
}
EXPECT_EXCEPTION(foo->callFnAsync(), "IPC client method call interrupted by disconnect.");
}

KJ_TEST("Destroying ProxyClient<> with destroy method after peer disconnect")
Expand Down
Loading