ci: bump timeout factor to 40#263
Merged
ryanofsky merged 1 commit intobitcoin-core:masterfrom Mar 25, 2026
Merged
Conversation
Matches the default TEST_RUNNER_TIMEOUT_FACTOR on Bitcoin Core CI.
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please copy-paste |
Member
Author
|
I suggest running this PR a few times, optionally after #256 is merged, to see if the timeout is long enough.
https://github.com/bitcoin-core/libmultiprocess/actions/runs/23559105412/job/68593864277?pr=263 Resource exhaustion? |
Collaborator
|
Code review ACK 09f10e5. Obviously good to match bitcoin core timeouts when running bitcoin core tests. Tests exiting with SIGTERM (https://github.com/bitcoin-core/libmultiprocess/actions/runs/23559105412/job/68593864277?pr=263) obviously is concerning, but I don't think there is a way they could be caused by this change, unless I am missing something. So I think I will merge this to unblock other PRs. |
Collaborator
Member
Author
|
I'm going to try to reduce See #264 |
Sjors
added a commit
to Sjors/libmultiprocess
that referenced
this pull request
Mar 26, 2026
The timeout factor increase in bitcoin-core#263 reliably causes SIGTERM/143 exit code errors. https://github.com/bitcoin-core/libmultiprocess/actions/runs/23559105412/job/68593864277?pr=240 https://github.com/bitcoin-core/libmultiprocess/actions/runs/23559105412/job/68593864283?pr=240 https://github.com/bitcoin-core/libmultiprocess/actions/runs/23567207693/job/68621529932 https://github.com/bitcoin-core/libmultiprocess/actions/runs/23567207693/job/68621529938 https://github.com/bitcoin-core/libmultiprocess/actions/runs/23583136495/job/68670044896?pr=256 https://github.com/bitcoin-core/libmultiprocess/actions/runs/23583136495/job/68670044932?pr=256 https://github.com/bitcoin-core/libmultiprocess/actions/runs/23587830246/job/68685257102?pr=249 https://github.com/bitcoin-core/libmultiprocess/actions/runs/23587830246/job/68685257218?pr=249 Reduce the nproc multipliers to try and prevent that.
Sjors
added a commit
to Sjors/libmultiprocess
that referenced
this pull request
Mar 26, 2026
The timeout factor increase in bitcoin-core#263 reliably causes SIGTERM/143 exit code errors. https://github.com/bitcoin-core/libmultiprocess/actions/runs/23559105412/job/68593864277?pr=240 https://github.com/bitcoin-core/libmultiprocess/actions/runs/23559105412/job/68593864283?pr=240 https://github.com/bitcoin-core/libmultiprocess/actions/runs/23567207693/job/68621529932 https://github.com/bitcoin-core/libmultiprocess/actions/runs/23567207693/job/68621529938 https://github.com/bitcoin-core/libmultiprocess/actions/runs/23583136495/job/68670044896?pr=256 https://github.com/bitcoin-core/libmultiprocess/actions/runs/23583136495/job/68670044932?pr=256 https://github.com/bitcoin-core/libmultiprocess/actions/runs/23587830246/job/68685257102?pr=249 https://github.com/bitcoin-core/libmultiprocess/actions/runs/23587830246/job/68685257218?pr=249 Reduce the nproc multipliers to try and prevent that. Since that increases the runtime, also reduce the total number of runs.
Sjors
added a commit
to Sjors/libmultiprocess
that referenced
this pull request
Mar 26, 2026
The timeout factor increase in bitcoin-core#263 reliably causes SIGTERM/143 exit code errors. https://github.com/bitcoin-core/libmultiprocess/actions/runs/23559105412/job/68593864277?pr=240 https://github.com/bitcoin-core/libmultiprocess/actions/runs/23559105412/job/68593864283?pr=240 https://github.com/bitcoin-core/libmultiprocess/actions/runs/23567207693/job/68621529932 https://github.com/bitcoin-core/libmultiprocess/actions/runs/23567207693/job/68621529938 https://github.com/bitcoin-core/libmultiprocess/actions/runs/23583136495/job/68670044896?pr=256 https://github.com/bitcoin-core/libmultiprocess/actions/runs/23583136495/job/68670044932?pr=256 https://github.com/bitcoin-core/libmultiprocess/actions/runs/23587830246/job/68685257102?pr=249 https://github.com/bitcoin-core/libmultiprocess/actions/runs/23587830246/job/68685257218?pr=249 Reduce the nproc multipliers to try and prevent that. Since that increases the runtime, also reduce the total number of runs.
Sjors
added a commit
to Sjors/libmultiprocess
that referenced
this pull request
Mar 26, 2026
The timeout factor increase in bitcoin-core#263 reliably causes SIGTERM/143 exit code errors. https://github.com/bitcoin-core/libmultiprocess/actions/runs/23559105412/job/68593864277?pr=240 https://github.com/bitcoin-core/libmultiprocess/actions/runs/23559105412/job/68593864283?pr=240 https://github.com/bitcoin-core/libmultiprocess/actions/runs/23567207693/job/68621529932 https://github.com/bitcoin-core/libmultiprocess/actions/runs/23567207693/job/68621529938 https://github.com/bitcoin-core/libmultiprocess/actions/runs/23583136495/job/68670044896?pr=256 https://github.com/bitcoin-core/libmultiprocess/actions/runs/23583136495/job/68670044932?pr=256 https://github.com/bitcoin-core/libmultiprocess/actions/runs/23587830246/job/68685257102?pr=249 https://github.com/bitcoin-core/libmultiprocess/actions/runs/23587830246/job/68685257218?pr=249 Reduce the nproc multipliers to try and prevent that. Since that increases the runtime, also reduce the total number of runs.
Sjors
added a commit
to Sjors/libmultiprocess
that referenced
this pull request
Mar 26, 2026
The timeout factor increase in bitcoin-core#263 reliably causes SIGTERM/143 exit code errors. https://github.com/bitcoin-core/libmultiprocess/actions/runs/23559105412/job/68593864277?pr=240 https://github.com/bitcoin-core/libmultiprocess/actions/runs/23559105412/job/68593864283?pr=240 https://github.com/bitcoin-core/libmultiprocess/actions/runs/23567207693/job/68621529932 https://github.com/bitcoin-core/libmultiprocess/actions/runs/23567207693/job/68621529938 https://github.com/bitcoin-core/libmultiprocess/actions/runs/23583136495/job/68670044896?pr=256 https://github.com/bitcoin-core/libmultiprocess/actions/runs/23583136495/job/68670044932?pr=256 https://github.com/bitcoin-core/libmultiprocess/actions/runs/23587830246/job/68685257102?pr=249 https://github.com/bitcoin-core/libmultiprocess/actions/runs/23587830246/job/68685257218?pr=249 Reduce the nproc multipliers to try and prevent that. Since that increases the runtime, also reduce the total number of runs.
ryanofsky
added a commit
that referenced
this pull request
Mar 26, 2026
3360233 ci: reduce nproc multipliers (Sjors Provoost) Pull request description: The timeout factor increase in #263 reliably causes SIGTERM/143 exit code errors. https://github.com/bitcoin-core/libmultiprocess/actions/runs/23559105412/job/68593864277?pr=240 https://github.com/bitcoin-core/libmultiprocess/actions/runs/23559105412/job/68593864283?pr=240 https://github.com/bitcoin-core/libmultiprocess/actions/runs/23567207693/job/68621529932 https://github.com/bitcoin-core/libmultiprocess/actions/runs/23567207693/job/68621529938 https://github.com/bitcoin-core/libmultiprocess/actions/runs/23583136495/job/68670044896?pr=256 https://github.com/bitcoin-core/libmultiprocess/actions/runs/23583136495/job/68670044932?pr=256 https://github.com/bitcoin-core/libmultiprocess/actions/runs/23587830246/job/68685257102?pr=249 https://github.com/bitcoin-core/libmultiprocess/actions/runs/23587830246/job/68685257218?pr=249 Reduce the nproc multipliers to try and prevent that. ACKs for top commit: ryanofsky: Code review ACK 3360233. Thanks for the fix! Tree-SHA512: 2113c2c417edd69873f37353d0bc7428386b036ef6abedbbde2df103af335d30132a052d1cf0152b1200635e8b401ed2f26d56e2c2b89b65c9f08bc9acf9eaa3
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Mar 26, 2026
…bf18 ff0eed1bf18 refactor: Use loop variable in type-context.h ff1d8ba172a refactor: Move type-context.h getParams() call closer to use 1dbc59a4aa3 race fix: m_on_cancel called after request finishes 1643d05ba07 test: m_on_cancel called after request finishes f5509a31fcc race fix: getParams() called after request cancel 4a60c39f24a test: getParams() called after request cancel f11ec29ed20 race fix: worker thread destroyed before it is initialized a1d643348f4 test: worker thread destroyed before it is initialized e606fd84a8c Merge bitcoin-core/libmultiprocess#264: ci: reduce nproc multipliers 336023382c4 ci: reduce nproc multipliers b090beb9651 Merge bitcoin-core/libmultiprocess#256: ci: cache gnu32 nix store be8622816da ci: cache gnu32 nix store 975270b619c Merge bitcoin-core/libmultiprocess#263: ci: bump timeout factor to 40 09f10e5a598 ci: bump timeout factor to 40 db8f76ad290 Merge bitcoin-core/libmultiprocess#253: ci: run some Bitcoin Core CI jobs 55a9b557b19 ci: set Bitcoin Core CI test repetition fb0fc84d556 ci: add TSan job with instrumented libc++ 0f29c38725b ci: add Bitcoin Core IPC tests (ASan + macOS) 3f64320315d Merge bitcoin-core/libmultiprocess#262: ci: enable clang-tidy in macOS job, use nullptr cd9f8bdc9f0 Merge bitcoin-core/libmultiprocess#258: log: add socket connected info message and demote destroy logs to debug b5d6258a42f Merge bitcoin-core/libmultiprocess#255: fix: use unsigned char cast and sizeof in LogEscape escape sequence d94688e2c32 Merge bitcoin-core/libmultiprocess#251: Improved CustomBuildField for std::optional in IPC/libmultiprocess a9499fad755 mp: use nullptr with pthread_threadid_np f499e37850f ci: enable clang-tidy in macOS job 98f1352159d log: add socket connected info message and demote destroy logs to debug 554a481ea73 fix: use unsigned char cast and sizeof in LogEscape escape sequence 1977b9f3f65 Use std::forward in CustomBuildField for std::optional to allow move semantics, resolves FIXME 22bec918c97 Merge bitcoin-core/libmultiprocess#247: type-map: Work around LLVM 22 "out of bounds index" error 8a5e3ae6ed2 Merge bitcoin-core/libmultiprocess#242: proxy-types: add CustomHasField hook to map Cap'n Proto values to null C++ values e8d35246918 Merge bitcoin-core/libmultiprocess#246: doc: Bump version 8 > 9 97d877053b6 proxy-types: add CustomHasField hook for nullable decode paths 8c2f10252c9 refactor: add missing includes to mp/type-data.h b1638aceb40 doc: Bump version 8 > 9 f61af487217 type-map: Work around LLVM 22 "out of bounds index" error git-subtree-dir: src/ipc/libmultiprocess git-subtree-split: ff0eed1bf183627c89007e71d631f039bd61bfb5
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Mar 27, 2026
…bf18 ff0eed1bf18 refactor: Use loop variable in type-context.h ff1d8ba172a refactor: Move type-context.h getParams() call closer to use 1dbc59a4aa3 race fix: m_on_cancel called after request finishes 1643d05ba07 test: m_on_cancel called after request finishes f5509a31fcc race fix: getParams() called after request cancel 4a60c39f24a test: getParams() called after request cancel f11ec29ed20 race fix: worker thread destroyed before it is initialized a1d643348f4 test: worker thread destroyed before it is initialized e606fd84a8c Merge bitcoin-core/libmultiprocess#264: ci: reduce nproc multipliers 336023382c4 ci: reduce nproc multipliers b090beb9651 Merge bitcoin-core/libmultiprocess#256: ci: cache gnu32 nix store be8622816da ci: cache gnu32 nix store 975270b619c Merge bitcoin-core/libmultiprocess#263: ci: bump timeout factor to 40 09f10e5a598 ci: bump timeout factor to 40 db8f76ad290 Merge bitcoin-core/libmultiprocess#253: ci: run some Bitcoin Core CI jobs 55a9b557b19 ci: set Bitcoin Core CI test repetition fb0fc84d556 ci: add TSan job with instrumented libc++ 0f29c38725b ci: add Bitcoin Core IPC tests (ASan + macOS) 3f64320315d Merge bitcoin-core/libmultiprocess#262: ci: enable clang-tidy in macOS job, use nullptr cd9f8bdc9f0 Merge bitcoin-core/libmultiprocess#258: log: add socket connected info message and demote destroy logs to debug b5d6258a42f Merge bitcoin-core/libmultiprocess#255: fix: use unsigned char cast and sizeof in LogEscape escape sequence d94688e2c32 Merge bitcoin-core/libmultiprocess#251: Improved CustomBuildField for std::optional in IPC/libmultiprocess a9499fad755 mp: use nullptr with pthread_threadid_np f499e37850f ci: enable clang-tidy in macOS job 98f1352159d log: add socket connected info message and demote destroy logs to debug 554a481ea73 fix: use unsigned char cast and sizeof in LogEscape escape sequence 1977b9f3f65 Use std::forward in CustomBuildField for std::optional to allow move semantics, resolves FIXME 22bec918c97 Merge bitcoin-core/libmultiprocess#247: type-map: Work around LLVM 22 "out of bounds index" error 8a5e3ae6ed2 Merge bitcoin-core/libmultiprocess#242: proxy-types: add CustomHasField hook to map Cap'n Proto values to null C++ values e8d35246918 Merge bitcoin-core/libmultiprocess#246: doc: Bump version 8 > 9 97d877053b6 proxy-types: add CustomHasField hook for nullable decode paths 8c2f10252c9 refactor: add missing includes to mp/type-data.h b1638aceb40 doc: Bump version 8 > 9 f61af487217 type-map: Work around LLVM 22 "out of bounds index" error git-subtree-dir: src/ipc/libmultiprocess git-subtree-split: ff0eed1bf183627c89007e71d631f039bd61bfb5
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Mar 27, 2026
…da8f 70f632bda8f Merge bitcoin-core/libmultiprocess#265: ci: set LC_ALL in shell scripts 8e8e564259a Merge bitcoin-core/libmultiprocess#249: fixes for race conditions on disconnects 05d34cc2ec3 ci: set LC_ALL in shell scripts e606fd84a8c Merge bitcoin-core/libmultiprocess#264: ci: reduce nproc multipliers ff0eed1bf18 refactor: Use loop variable in type-context.h ff1d8ba172a refactor: Move type-context.h getParams() call closer to use 1dbc59a4aa3 race fix: m_on_cancel called after request finishes 1643d05ba07 test: m_on_cancel called after request finishes f5509a31fcc race fix: getParams() called after request cancel 4a60c39f24a test: getParams() called after request cancel f11ec29ed20 race fix: worker thread destroyed before it is initialized a1d643348f4 test: worker thread destroyed before it is initialized 336023382c4 ci: reduce nproc multipliers b090beb9651 Merge bitcoin-core/libmultiprocess#256: ci: cache gnu32 nix store be8622816da ci: cache gnu32 nix store 975270b619c Merge bitcoin-core/libmultiprocess#263: ci: bump timeout factor to 40 09f10e5a598 ci: bump timeout factor to 40 db8f76ad290 Merge bitcoin-core/libmultiprocess#253: ci: run some Bitcoin Core CI jobs 55a9b557b19 ci: set Bitcoin Core CI test repetition fb0fc84d556 ci: add TSan job with instrumented libc++ 0f29c38725b ci: add Bitcoin Core IPC tests (ASan + macOS) 3f64320315d Merge bitcoin-core/libmultiprocess#262: ci: enable clang-tidy in macOS job, use nullptr cd9f8bdc9f0 Merge bitcoin-core/libmultiprocess#258: log: add socket connected info message and demote destroy logs to debug b5d6258a42f Merge bitcoin-core/libmultiprocess#255: fix: use unsigned char cast and sizeof in LogEscape escape sequence d94688e2c32 Merge bitcoin-core/libmultiprocess#251: Improved CustomBuildField for std::optional in IPC/libmultiprocess a9499fad755 mp: use nullptr with pthread_threadid_np f499e37850f ci: enable clang-tidy in macOS job 98f1352159d log: add socket connected info message and demote destroy logs to debug 554a481ea73 fix: use unsigned char cast and sizeof in LogEscape escape sequence 1977b9f3f65 Use std::forward in CustomBuildField for std::optional to allow move semantics, resolves FIXME 22bec918c97 Merge bitcoin-core/libmultiprocess#247: type-map: Work around LLVM 22 "out of bounds index" error 8a5e3ae6ed2 Merge bitcoin-core/libmultiprocess#242: proxy-types: add CustomHasField hook to map Cap'n Proto values to null C++ values e8d35246918 Merge bitcoin-core/libmultiprocess#246: doc: Bump version 8 > 9 97d877053b6 proxy-types: add CustomHasField hook for nullable decode paths 8c2f10252c9 refactor: add missing includes to mp/type-data.h b1638aceb40 doc: Bump version 8 > 9 f61af487217 type-map: Work around LLVM 22 "out of bounds index" error git-subtree-dir: src/ipc/libmultiprocess git-subtree-split: 70f632bda8f80449b6240f98da768206a535a04e
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Mar 30, 2026
…da8f 70f632bda8f Merge bitcoin-core/libmultiprocess#265: ci: set LC_ALL in shell scripts 8e8e564259a Merge bitcoin-core/libmultiprocess#249: fixes for race conditions on disconnects 05d34cc2ec3 ci: set LC_ALL in shell scripts e606fd84a8c Merge bitcoin-core/libmultiprocess#264: ci: reduce nproc multipliers ff0eed1bf18 refactor: Use loop variable in type-context.h ff1d8ba172a refactor: Move type-context.h getParams() call closer to use 1dbc59a4aa3 race fix: m_on_cancel called after request finishes 1643d05ba07 test: m_on_cancel called after request finishes f5509a31fcc race fix: getParams() called after request cancel 4a60c39f24a test: getParams() called after request cancel f11ec29ed20 race fix: worker thread destroyed before it is initialized a1d643348f4 test: worker thread destroyed before it is initialized 336023382c4 ci: reduce nproc multipliers b090beb9651 Merge bitcoin-core/libmultiprocess#256: ci: cache gnu32 nix store be8622816da ci: cache gnu32 nix store 975270b619c Merge bitcoin-core/libmultiprocess#263: ci: bump timeout factor to 40 09f10e5a598 ci: bump timeout factor to 40 db8f76ad290 Merge bitcoin-core/libmultiprocess#253: ci: run some Bitcoin Core CI jobs 55a9b557b19 ci: set Bitcoin Core CI test repetition fb0fc84d556 ci: add TSan job with instrumented libc++ 0f29c38725b ci: add Bitcoin Core IPC tests (ASan + macOS) 3f64320315d Merge bitcoin-core/libmultiprocess#262: ci: enable clang-tidy in macOS job, use nullptr cd9f8bdc9f0 Merge bitcoin-core/libmultiprocess#258: log: add socket connected info message and demote destroy logs to debug b5d6258a42f Merge bitcoin-core/libmultiprocess#255: fix: use unsigned char cast and sizeof in LogEscape escape sequence d94688e2c32 Merge bitcoin-core/libmultiprocess#251: Improved CustomBuildField for std::optional in IPC/libmultiprocess a9499fad755 mp: use nullptr with pthread_threadid_np f499e37850f ci: enable clang-tidy in macOS job 98f1352159d log: add socket connected info message and demote destroy logs to debug 554a481ea73 fix: use unsigned char cast and sizeof in LogEscape escape sequence 1977b9f3f65 Use std::forward in CustomBuildField for std::optional to allow move semantics, resolves FIXME 22bec918c97 Merge bitcoin-core/libmultiprocess#247: type-map: Work around LLVM 22 "out of bounds index" error 8a5e3ae6ed2 Merge bitcoin-core/libmultiprocess#242: proxy-types: add CustomHasField hook to map Cap'n Proto values to null C++ values e8d35246918 Merge bitcoin-core/libmultiprocess#246: doc: Bump version 8 > 9 97d877053b6 proxy-types: add CustomHasField hook for nullable decode paths 8c2f10252c9 refactor: add missing includes to mp/type-data.h b1638aceb40 doc: Bump version 8 > 9 f61af487217 type-map: Work around LLVM 22 "out of bounds index" error git-subtree-dir: src/ipc/libmultiprocess git-subtree-split: 70f632bda8f80449b6240f98da768206a535a04e
fanquake
added a commit
to bitcoin/bitcoin
that referenced
this pull request
Mar 30, 2026
…n disconnects 2478a15 Squashed 'src/ipc/libmultiprocess/' changes from 1868a84451f..70f632bda8f (Ryan Ofsky) Pull request description: Includes: - bitcoin-core/libmultiprocess#246 - bitcoin-core/libmultiprocess#242 - bitcoin-core/libmultiprocess#247 - bitcoin-core/libmultiprocess#251 - bitcoin-core/libmultiprocess#255 - bitcoin-core/libmultiprocess#258 - bitcoin-core/libmultiprocess#262 - bitcoin-core/libmultiprocess#253 - bitcoin-core/libmultiprocess#263 - bitcoin-core/libmultiprocess#256 - bitcoin-core/libmultiprocess#264 - bitcoin-core/libmultiprocess#249 - bitcoin-core/libmultiprocess#265 The main change is bitcoin-core/libmultiprocess#249 which fixes 3 intermittent race conditions detected in bitcoin core CI and antithesis: #34711/#34756, #34777, and #34782. The changes can be verified by running `test/lint/git-subtree-check.sh src/ipc/libmultiprocess` as described in [developer notes](https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#subtrees) and [lint instructions](https://github.com/bitcoin/bitcoin/tree/master/test/lint#git-subtree-checksh) ACKs for top commit: Sjors: ACK 613a548 ismaelsadeeq: ACK 613a548 Tree-SHA512: d99eebc8b4f45b3c3099298167362cf5e7f3e9e622eef9f17af56388ee5207d77a04b915b2a5a894493e0395aeda70111216f2da0d2a6553f4f6396b3d31a744
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matches the default
TEST_RUNNER_TIMEOUT_FACTORon Bitcoin Core CI.Should prevent false positives like #256 (comment)
That test relies on a timeout: