Closed
Conversation
beati
commented
Jan 9, 2026
beati
commented
- In bitcoin-qt, there is under Settings the "Mask values" option
- When a wallet is open and the "Mask values" checkbox is checked, the "Transactions" tab is disabled
- When no wallet was open and the "Mask values" checkbox was checked and a wallet was opened, the "Transactions" tab was enabled
- This fix changes this, so that there is always the same behavior
- The "Transactions" tab is now always disabled when the "Mask values" checkbox is checked
- This fix is manually tested on the fork
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process. |
hebasto
changed the title
Member
|
Does this PR solve the same issue as #815? |
Author
Yes, it looks like. |
Member
|
Thank you for your contribution!
An alternative approach was recently merged, as there was a consensus among developers regarding the preferred code structure (see #815 (comment) and #815 (review)). Because that solution has already landed, I am closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.