Add coins (UTXOs) tab and makes it view-only

[ghost]

GUI: Add coins tab and sets view-only mode

Adds Coins (UTXOs) tab at the top and:

• Removes selection checkboxes from the dialog
• Disables coin selection functionality
• Maintains UTXO viewing capabilities
• Removes all the information from the top area of the dialog.

The following pictures depict how the GUI would look like:

[DrahtBot]

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type	Reviewers
Concept NACK	hebasto

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

• #815 (Bugfix on TransactionsView - Disable if privacy mode is set during wallet selection by pablomartin4btc)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

[hebasto]

cc @achow101 @Sjors

[ghost]

So, I've got 3 failed pipeline checks. I'll need to check them.

[ghost]

Pipeline issues should be fixed now.

[luke-jr]

Should probably only be available if advanced coin control is enabled in settings, and maybe only on a menu even then (if it made sense to do it as a tab, it should be within the main window, not a new window).

The SVG source for the new icon should also be included.

[ghost]

Should probably only be available if advanced coin control is enabled in settings, and maybe only on a menu even then (if it made sense to do it as a tab, it should be within the main window, not a new window).

The SVG source for the new icon should also be included.

Thanks for the comments! I will check soon!

[ghost]

So I've made the changes.

Specifically:

1. I added the .svg file, like discussed.
2. I set the coins tab to be in the same window and not open a new one.
3. I set the coins tab to be visible only if "coin control features" are enabled in the advanced options.

The way it works is:

When coin control features are disabled, then the "Coins" tab will be hidden, like in this picture:

Once the user enables coin control features, then the "Coins" tab will appear, like so:

If the user has the Coins tab enabled (i.e has coin control features enabled) and then disables it, the "Coins" tab will hide again and the user will be transferred to the "Overview" tab.

And lastly, here is the way that the coins tab will look like:

I kept the quantity and the amount visible, to be able to see some summaries easier. I also kept the tree mode and list mode, to facilitate UTXO viewing, especially for wallets with multiple UTXOs.

[ghost]

@hebasto Hello! The “CentOS, depends, gui” job fails and the reason is that it references ./ci/test/00_setup_env_native_centos.sh, which isn’t in this repo. Could we skip that job or rerun on Cirrus instead?

if I'm missing something here, or if I should create my PR checking out from another branch (not the master), let me know!

[hebasto]

The PR description lacks motivation for the new feature.

This change significantly affects the UX, and input from designers would be welcome. However, it is worth noting that that designers are currently focused on the QML GUI (see https://github.com/bitcoin-core/gui-qml/tree/qt6 and https://bitcoincore.app/). Feel free to join https://bitcoindesign.slack.com and engage designers in discussion.

Concept NACK for this new feature in the Qt Widget-based GUI.

[ghost]

I'm not sure what the comment about motivation means, but I appreciate your time.

[hebasto]

I'm not sure what the comment about motivation means...

It means that the following only describes the feature itself, without providing the goals, use cases, or rationale behind it:

GUI: Add coins tab and sets view-only mode

Adds Coins (UTXOs) tab at the top and:

• Removes selection checkboxes from the dialog

• Disables coin selection functionality

• Maintains UTXO viewing capabilities

• Removes all the information from the top area of the dialog.

[ghost]

I'm not sure what the comment about motivation means...

It means that the following only describes the feature itself, without providing the goals, use cases, or rationale behind it:

GUI: Add coins tab and sets view-only mode

Adds Coins (UTXOs) tab at the top and:

• Removes selection checkboxes from the dialog

• Disables coin selection functionality

• Maintains UTXO viewing capabilities

• Removes all the information from the top area of the dialog.

Ok you are correct! I will think about redefining the goals and explaining the purpose better.
Again, thanks for the feedback.

[DrahtBot]

🐙 This pull request conflicts with the target branch and needs rebase.