Inheritables in root#249
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Enables parsing and ingestion of inheritable resources at the repository root, including support for ingest -p / to update only the root (non-recursively), and updates inheritable-resource lookups to use a generic query helper.
Changes:
- Allow
ingest -p /to target the root directory and route that mode toupdateRoot. - Add
inheritableResourcesFromPathand use it to ingest root-level inheritables. - Introduce a generic
getInheritableDB helper and reuse it for CSS + favicon resolution.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/ingest.ts | Accept / as a special-case CLI path and document it in help text. |
| ingest/index.ts | Skip per-prefix ingestion for / and ensure updateRoot runs when requested. |
| ingest/inheritables.ts | Factor out root/prefix inheritable resource discovery into inheritableResourcesFromPath. |
| ingest/updatePaths.ts | Reuse build-id creation, ingest root inheritables, and run cleanup for root. |
| api/content.ts | Add a generic inheritable lookup and reuse it for CSS and favicon selection. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
99a667d to
33f945a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #242.
ingest -p /ingest the root directory (non-recursively)