Add Markdown table support#243
Merged
Merged
Conversation
Contributor
Author
|
Reviewer note: this updates both MDX compile paths intentionally. The small CSS block is included in the same PR because parser support alone would render unstyled semantic tables in prose. The rules are scoped to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add GitHub-style Markdown table support to notes content.
This changes the MDX pipeline to recognize GFM tables, adds conservative prose-scoped table styling, and documents the capability briefly in the README.
Why
Notes content currently renders pipe-delimited table syntax as plain text because the MDX compiler is not using
remark-gfm.There are two MDX compile paths in this repository:
<Question>blocksBoth paths need the same table parsing support. Updating only the main serializer would leave mixed content inconsistent or broken.
Changes
remark-gfmto dependenciesremark-gfminingest/md-helpers.tsremark-gfminingest/questions.ts.prosetable styling instyles/globals.scssScope
This PR is intentionally small:
Validation
<Question>yarn ingestis currently blocked by an unrelated existing TypeScript issue inscripts/ingest.tsrelated totree-killtypings, so full ingest validation was not possible within this change.