Add support for Specification Extensions#96
Closed
isomorpheme wants to merge 2 commits intobiocad:masterfrom
Closed
Add support for Specification Extensions#96isomorpheme wants to merge 2 commits intobiocad:masterfrom
isomorpheme wants to merge 2 commits intobiocad:masterfrom
Conversation
isomorpheme
force-pushed
the
specification-extensions
branch
5 times, most recently
from
13ea21e to
92fec3b
Compare
Co-authored-by: Alex Biehl <alex@scarf.sh> Co-authored-by: Avery <thecommunistduck@hotmail.co.uk>
isomorpheme
force-pushed
the
specification-extensions
branch
from
92fec3b to
c1ac4fb
Compare
Author
|
I'm not planning on working on this anymore so I'm closing this PR, but if anyone else wants to pick it back up then I'm happy to answer questions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is more or less a rebase + squash of #43, with some extra fixes & improvements, for example the original PR accidentally added a mandatory
extensionsproperty to some objects, and just amended the tests to allow this for some reason.Closes #11.